Skip to content

Commit bb541e7

Browse files
author
AI Assistant
committed
chore: improve slack messaging
1 parent 15da539 commit bb541e7

File tree

6 files changed

+11
-16
lines changed

6 files changed

+11
-16
lines changed

.github/workflows/deploy-beta.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ jobs:
155155
needs: get-deploy-inputs
156156
if: ${{ inputs.deploy_to_npm }}
157157
with:
158-
is_called: true
159158
environment: beta
160159
bugsnag_release_stage: beta
161160
version_suffix: ${{ needs.get-deploy-inputs.outputs.version_suffix }}

.github/workflows/deploy-npm.yml

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ on:
44
workflow_dispatch:
55
workflow_call:
66
inputs:
7-
is_called:
8-
type: string
9-
required: true
107
base_version:
118
type: string
129
required: false
@@ -58,7 +55,7 @@ jobs:
5855
name: Deploy to NPM
5956
# As we publish the NPM package with provenance, we must use GitHub-hosted runners
6057
runs-on: ubuntu-latest
61-
if: ${{ inputs.is_called == 'true' || (github.event_name == 'workflow_dispatch' && startsWith(github.ref, 'refs/tags/v')) }}
58+
if: ${{ github.workflow_ref != '' || (github.event_name == 'workflow_dispatch' && startsWith(github.ref, 'refs/tags/v')) }}
6259

6360
steps:
6461
- name: Checkout
@@ -222,7 +219,7 @@ jobs:
222219
PROJECT_NAME: ${{ format('JS SDK NPM Package{0}', (inputs.environment == 'staging' && ' - Staging') || (inputs.environment == 'development' && ' - Development') || (inputs.environment == 'beta' && ' - Beta') || '') }}
223220
NPM_PACKAGE_URL: 'https://www.npmjs.com/package/@rudderstack/analytics-js'
224221
RELEASES_URL: 'https://github.com/rudderlabs/rudder-sdk-js/releases/tag/@rudderstack/analytics-js@'
225-
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }}
222+
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}/jobs/{3}', github.server_url, github.repository, github.run_id, github.job) }}
226223
ACTOR_URL: ${{ format('{0}/{1}', github.server_url, github.actor) }}
227224
ACTOR: ${{ github.actor }}
228225
with:
@@ -262,7 +259,7 @@ jobs:
262259
"elements": [
263260
{
264261
"type": "mrkdwn",
265-
"text": ":package: ${{ (github.event_name == 'workflow_dispatch' && format('Published by <{0}|{1}>', env.ACTOR_URL, env.ACTOR)) || (inputs.trigger_source && inputs.trigger_source) }}"
262+
"text": ":package: ${{ inputs.trigger_source || format('Published by <{0}|{1}>', env.ACTOR_URL, env.ACTOR) }}"
266263
},
267264
{
268265
"type": "mrkdwn",
@@ -293,7 +290,7 @@ jobs:
293290
PROJECT_NAME: ${{ format('JS SDK Service Worker NPM Package{0}', (inputs.environment == 'staging' && ' - Staging') || (inputs.environment == 'development' && ' - Development') || (inputs.environment == 'beta' && ' - Beta') || '') }}
294291
NPM_PACKAGE_URL: 'https://www.npmjs.com/package/@rudderstack/analytics-js-service-worker'
295292
RELEASES_URL: 'https://github.com/rudderlabs/rudder-sdk-js/releases/tag/@rudderstack/analytics-js-service-worker@'
296-
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }}
293+
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}/jobs/{3}', github.server_url, github.repository, github.run_id, github.job) }}
297294
ACTOR_URL: ${{ format('{0}/{1}', github.server_url, github.actor) }}
298295
ACTOR: ${{ github.actor }}
299296
with:
@@ -333,7 +330,7 @@ jobs:
333330
"elements": [
334331
{
335332
"type": "mrkdwn",
336-
"text": ":package: ${{ (github.event_name == 'workflow_dispatch' && format('Published by <{0}|{1}>', env.ACTOR_URL, env.ACTOR)) || (inputs.trigger_source && inputs.trigger_source) }}"
333+
"text": ":package: ${{ inputs.trigger_source || format('Published by <{0}|{1}>', env.ACTOR_URL, env.ACTOR) }}"
337334
},
338335
{
339336
"type": "mrkdwn",
@@ -353,7 +350,7 @@ jobs:
353350
PROJECT_NAME: ${{ format('JS SDK Cookies Utilities{0}', (inputs.environment == 'staging' && ' - Staging') || (inputs.environment == 'development' && ' - Development') || (inputs.environment == 'beta' && ' - Beta') || '') }}
354351
NPM_PACKAGE_URL: 'https://www.npmjs.com/package/@rudderstack/analytics-js-cookies'
355352
RELEASES_URL: 'https://github.com/rudderlabs/rudder-sdk-js/releases/tag/@rudderstack/analytics-js-cookies@'
356-
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }}
353+
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}/jobs/{3}', github.server_url, github.repository, github.run_id, github.job) }}
357354
ACTOR_URL: ${{ format('{0}/{1}', github.server_url, github.actor) }}
358355
ACTOR: ${{ github.actor }}
359356
with:
@@ -393,7 +390,7 @@ jobs:
393390
"elements": [
394391
{
395392
"type": "mrkdwn",
396-
"text": ":package: ${{ (github.event_name == 'workflow_dispatch' && format('Published by <{0}|{1}>', env.ACTOR_URL, env.ACTOR)) || (inputs.trigger_source && inputs.trigger_source) }}"
393+
"text": ":package: ${{ inputs.trigger_source || format('Published by <{0}|{1}>', env.ACTOR_URL, env.ACTOR) }}"
397394
},
398395
{
399396
"type": "mrkdwn",

.github/workflows/deploy-sanity-suite.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ jobs:
159159
PROJECT_NAME: ${{ format('Sanity Suite - {0}', (inputs.environment == 'production' && 'Production') || (inputs.environment == 'staging' && 'Staging') || (inputs.environment == 'development' && 'Development') || 'Beta') }}
160160
CDN_URL: 'https://cdn.rudderlabs.com/sanity-suite${{ env.SUITE_CDN_PATH }}/v3/cdn/index.html'
161161
LINK_TEXT: ${{ ((inputs.environment == 'development' && format('v{0} - Development', env.CURRENT_VERSION_VALUE)) || (inputs.environment == 'staging' && format('v{0} - Staging', env.CURRENT_VERSION_VALUE)) || (inputs.environment == 'beta' && format('v{0} - Beta', env.CURRENT_VERSION_VALUE)) || format('v{0}', env.CURRENT_VERSION_VALUE)) }}
162-
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }}
162+
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}/jobs/{3}', github.server_url, github.repository, github.run_id, github.job) }}
163163
ACTOR_URL: ${{ format('{0}/{1}', github.server_url, github.actor) }}
164164
ACTOR: ${{ github.actor }}
165165
with:

.github/workflows/deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ jobs:
289289
CDN_URL: ${{ format('https://cdn.rudderlabs.com/{0}/modern/rsa.min.js', inputs.s3_dir_path) }}
290290
RELEASES_URL: 'https://github.com/rudderlabs/rudder-sdk-js/releases/tag/@rudderstack/analytics-js@'
291291
LINK_TEXT: ${{ (inputs.environment == 'development' && 'Development') || (inputs.environment == 'staging' && format('v{0} - Staging', env.CURRENT_VERSION_VALUE)) || format('v{0}', env.CURRENT_VERSION_VALUE) }}
292-
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }}
292+
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}/jobs/{3}', github.server_url, github.repository, github.run_id, github.job) }}
293293
ACTOR: ${{ github.actor }}
294294
ACTOR_URL: ${{ format('{0}/{1}', github.server_url, github.actor) }}
295295
with:

.github/workflows/publish-new-release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ jobs:
171171
PROJECT_NAME: 'JS SDK Monorepo'
172172
TAG_COMPARE_URL: 'https://github.com/rudderlabs/rudder-sdk-js/compare/'
173173
RELEASES_URL: 'https://github.com/rudderlabs/rudder-sdk-js/releases/tag/'
174-
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }}
174+
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}/jobs/{3}', github.server_url, github.repository, github.run_id, github.job) }}
175175
ACTOR_URL: ${{ format('{0}/{1}', github.server_url, github.actor) }}
176176
ACTOR: ${{ github.actor }}
177177
with:
@@ -231,7 +231,6 @@ jobs:
231231
name: Publish packages to NPM
232232
uses: ./.github/workflows/deploy-npm.yml
233233
with:
234-
is_called: 'true'
235234
trigger_source: ${{ needs.get-release-inputs.outputs.trigger_source }}
236235
monorepo_release_version: ${{ needs.get-release-inputs.outputs.release_version }}
237236
release_ticket_id: ${{ needs.get-release-inputs.outputs.release_ticket_id }}

.github/workflows/rollback.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ jobs:
188188
CDN_URL: ${{ format('https://cdn.rudderlabs.com/{0}/modern/rsa.min.js', env.LATEST_VERSION_DIR_NAME) }}
189189
RELEASES_URL: 'https://github.com/rudderlabs/rudder-sdk-js/releases/tag/@rudderstack/analytics-js@'
190190
LINK_TEXT: ${{ format('v{0}', env.ROLLBACK_VERSION_VALUE) }}
191-
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }}
191+
GITHUB_RUN_URL: ${{ format('{0}/{1}/actions/runs/{2}/jobs/{3}', github.server_url, github.repository, github.run_id, github.job) }}
192192
ACTOR_URL: ${{ format('{0}/{1}', github.server_url, github.actor) }}
193193
ACTOR: ${{ github.actor }}
194194
with:

0 commit comments

Comments
 (0)