Tickets.generate_login_ticket should not take an argument #22
Description
Hi, I am building a custom rubycas-server in rails based on rubycas-server-core. Up until now I have noticed some minibugs:
1)Why generate_login_ticket takes an argument (client) ? CAS protocol does not specify anything like that. Also, in Sinatra-based rubycas-server generate_login_ticket is implemented without an argument so I guess it is a mistake?
Also you you have success = false in cas.rb (line 121 in validate_ticket_granting_ticket method) which is never used. Instead you rely on error variable, in the sense that if no error has appeared, you return nil (which is convenient for if statements). I guess a mini mistake too ? Notice that in the Sinatra-based rubycas-server you have again success=false (which is useless) but you rely only in error as I explained.