added logging, abstracted away version being extracted from tag name substring

Author: retailcoder

Rubberduck.Core/UI/Command/VersionCheckCommand.cs

@@ -44,6 +44,12 @@ public VersionCheckCommand(IVersionCheckService versionCheck, IMessageBox prompt
         protected override async void OnExecute(object parameter)
         {
             var settings = _config.Read().UserSettings.GeneralSettings;
+            if (_versionCheck.IsDebugBuild)
+            {
+                Logger.Info("Version check skipped for debug build.");
+                return;
+            }
+
             Logger.Info("Executing version check...");
 
             var tokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(5));
@@ -71,6 +77,14 @@ await _versionCheck
                         {
                             PromptAndBrowse(t.Result, settings.IncludePreRelease);
                         }
+                        else
+                        {
+                            Logger.Info("Version check skips notification of an existing newer version available.");
+                        }
+                    }
+                    else
+                    {
+                        Logger.Info("Version check completed: running current latest.");
                     }
                 });
         }

Rubberduck.Core/VersionCheck/Tag.cs

@@ -11,6 +11,10 @@ public class Tag
         public int InstallerDownloads { get; set; }
         public bool IsPreRelease { get; set; }
 
+        public Version Version => new Version(IsPreRelease
+            ? Name.Substring("prerelease-v".Length)
+            : Name.Substring("v".Length));
+
         public virtual ICollection<TagAsset> TagAssets { get; set; } = new List<TagAsset>();
     }
 }

Rubberduck.Core/VersionCheck/VersionCheckService.cs

@@ -1,4 +1,5 @@
 using Newtonsoft.Json;
+using NLog;
 using Rubberduck.Settings;
 using System;
 using System.Linq;
@@ -9,6 +10,8 @@ namespace Rubberduck.VersionCheck
 {
     public class VersionCheckService : IVersionCheckService
     {
+        private static readonly ILogger _logger = LogManager.GetCurrentClassLogger();
+
         /// <param name="version">That would be the version of the assembly for the <c>_Extension</c> class.</param>
         public VersionCheckService(Version version)
         {
@@ -32,14 +35,14 @@ public async Task<Version> GetLatestVersionAsync(GeneralSettings settings, Cance
             using (var client = new PublicApiClient())
             {
                 var tags = await client.GetLatestTagsAsync(token);
-                var next = tags.Single(e => e.IsPreRelease).Name;
-                var main = tags.Single(e => !e.IsPreRelease).Name;
 
-                var version = settings.IncludePreRelease
-                    ? next.Substring("Prerelease-v".Length)
-                    : main.Substring("v".Length);
+                var next = tags.Single(e => e.IsPreRelease);
+                var main = tags.Single(e => !e.IsPreRelease);
+                _logger.Info($"Main: v{main.Version.ToString(3)}; Next: v{next.Version.ToString(4)}");
+
+                _latestVersion = settings.IncludePreRelease ? next.Version : main.Version;
+                _logger.Info($"Check prerelease: {settings.IncludePreRelease}; latest: v{_latestVersion.ToString(4)}");
 
-                _latestVersion = new Version(version);
                 return _latestVersion;
             }
         }