Fix ParameterCanBeByVal bugs

Author: Hosch250

RetailCoder.VBE/Inspections/ParameterCanBeByValInspection.cs

@@ -74,28 +74,16 @@ private static bool IsUsedAsByRefParam(IEnumerable<Declaration> declarations, De
                     .ThenBy(arg => arg.Selection.StartColumn)
                     .ToArray();
 
-                for (var i = 0; i < calledProcedureArgs.Count(); i++)
+                foreach (var declaration in calledProcedureArgs)
                 {
-                    if (((VBAParser.ArgContext)calledProcedureArgs[i].Context).BYVAL() != null)
+                    if (((VBAParser.ArgContext)declaration.Context).BYVAL() != null)
                     {
                         continue;
                     }
 
-                    foreach (var reference in item)
+                    foreach (var reference in declaration.References)
                     {
-                        if (!(reference.Context is VBAParser.ArgContext))
-                        {
-                            continue;
-                        }
-                        var context = ((dynamic)reference.Context.Parent).argsCall() as VBAParser.ArgContext;
-                        if (context == null)
-                        {
-                            continue;
-                        }
-                        if (parameter.IdentifierName == context.GetText())
-                        {
-                            return true;
-                        }
+                        if (reference.IsAssignment) { return true; }
                     }
                 }
             }

RubberduckTests/Inspections/ParameterCanBeByValInspectionTests.cs

@@ -218,6 +218,95 @@ public void GivenArrayParameter_ReturnsNoResult()
             Assert.AreEqual(0, results.Count);
         }
 
+        [TestMethod]
+        [TestCategory("Inspections")]
+        public void ParameterCanBeByVal_ReturnsResult_PassedToByRefProc_NoAssignment()
+        {
+            const string inputCode =
+@"Sub DoSomething(foo As Integer)
+    DoSomethingElse foo
+End Sub
+
+Sub DoSomethingElse(ByVal bar As Integer)
+End Sub";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState(vbe.Object, new Mock<ISinks>().Object));
+
+            parser.Parse(new CancellationTokenSource());
+            if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var inspection = new ParameterCanBeByValInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(1, inspectionResults.Count());
+        }
+
+        [TestMethod]
+        [TestCategory("Inspections")]
+        public void ParameterCanBeByVal_DoesNotReturnResult_PassedToByRefProc_WithAssignment()
+        {
+            const string inputCode =
+@"Sub DoSomething(foo As Integer)
+    DoSomethingElse foo
+End Sub
+
+Sub DoSomethingElse(ByRef bar As Integer)
+    bar = 42
+End Sub";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState(vbe.Object, new Mock<ISinks>().Object));
+
+            parser.Parse(new CancellationTokenSource());
+            if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var inspection = new ParameterCanBeByValInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.IsFalse(inspectionResults.Any());
+        }
+
+        [TestMethod]
+        [TestCategory("Inspections")]
+        public void ParameterCanBeByVal_ReturnsResult_PassedToByValProc_WithAssignment()
+        {
+            const string inputCode =
+@"Sub DoSomething(foo As Integer)
+    DoSomethingElse foo
+End Sub
+
+Sub DoSomethingElse(ByVal bar As Integer)
+    bar = 42
+End Sub";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState(vbe.Object, new Mock<ISinks>().Object));
+
+            parser.Parse(new CancellationTokenSource());
+            if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var inspection = new ParameterCanBeByValInspection(parser.State);
+            var inspectionResults = inspection.GetInspectionResults();
+
+            Assert.AreEqual(1, inspectionResults.Count());
+        }
+
         [TestMethod]
         [TestCategory("Inspections")]
         public void ParameterCanBeByVal_Ignored_DoesNotReturnResult()