Stop ReturnsValue from being static as it should not be shared across multiple fakes - fixes #5944

tommy9 · tommy9 · commit adab10c687e1 · 2022-11-22T17:51:04.000Z
diff --git a/Rubberduck.Main/ComClientLibrary/UnitTesting/FakeBase.cs b/Rubberduck.Main/ComClientLibrary/UnitTesting/FakeBase.cs
@@ -75,7 +75,7 @@ protected bool TrySetReturnValue(bool any = false)
 
         #region IFake
 
-        private static readonly List<ReturnValueInfo> ReturnValues = new List<ReturnValueInfo>();
+        private readonly List<ReturnValueInfo> ReturnValues = new List<ReturnValueInfo>();
         public virtual void Returns(object value, int invocation = FakesProvider.AllInvocations)
         {
             ReturnValues.Add(new ReturnValueInfo(invocation, string.Empty, string.Empty, value));

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ protected bool TrySetReturnValue(bool any = false)`
`75`	`75`
`76`	`76`	`#region IFake`
`77`	`77`
`78`		`- private static readonly List<ReturnValueInfo> ReturnValues = new List<ReturnValueInfo>();`
	`78`	`+ private readonly List<ReturnValueInfo> ReturnValues = new List<ReturnValueInfo>();`
`79`	`79`	`public virtual void Returns(object value, int invocation = FakesProvider.AllInvocations)`
`80`	`80`	`{`
`81`	`81`	`ReturnValues.Add(new ReturnValueInfo(invocation, string.Empty, string.Empty, value));`