Skip to content

Commit ad162f1

Browse files
committed
added more tests
1 parent 50d5e5a commit ad162f1

File tree

2 files changed

+37
-0
lines changed

2 files changed

+37
-0
lines changed

RubberduckTests/Inspections/ImplicitActiveSheetReferenceInspectionTests.cs

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,27 @@ End Sub
154154
Assert.AreEqual(0, InspectionResultsForModules(modules, ReferenceLibrary.Excel, DefaultDocumentModuleSupertypeNames).Count());
155155
}
156156

157+
[Test]
158+
[Category("Inspections")]
159+
public void ImplicitActiveSheetReference_NoResultForWorksheetFunction()
160+
{
161+
const string inputCode =
162+
@"Sub foo()
163+
Debug.Print GetSheet.Cells(1, 1)
164+
End Sub
165+
166+
Private Function GetSheet() As Worksheet
167+
End Function
168+
";
169+
var modules = new (string, string, ComponentType)[]
170+
{
171+
("ThisWorkbook", string.Empty, ComponentType.Document),
172+
("Sheet1", string.Empty, ComponentType.Document),
173+
("Module1", inputCode, ComponentType.StandardModule)
174+
};
175+
Assert.AreEqual(0, InspectionResultsForModules(modules, ReferenceLibrary.Excel, DefaultDocumentModuleSupertypeNames).Count());
176+
}
177+
157178
[Test]
158179
[Category("Inspections")]
159180
public void ImplicitActiveSheetReference_Ignored_DoesNotReportRange()

RubberduckTests/Inspections/ImplicitContainingSheetreferenceInspectionTests.cs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,22 @@ End Sub
126126
Assert.AreEqual(0, InspectionResultsInWorksheet(inputCode).Count());
127127
}
128128

129+
[Test]
130+
[Category("Inspections")]
131+
public void ImplicitContainingSheetReference_NoResultForWorksheetFunction()
132+
{
133+
const string inputCode =
134+
@"Sub foo()
135+
Dim arr1 As Variant
136+
arr1 = GetSheet.Range(""A1:B2"")
137+
End Sub
138+
139+
Function GetSheet() As Worksheet
140+
End Function
141+
";
142+
Assert.AreEqual(0, InspectionResultsInWorksheet(inputCode).Count());
143+
}
144+
129145
[Test]
130146
[Category("Inspections")]
131147
public void InspectionName()

0 commit comments

Comments
 (0)