extracted IWebNavigator interface

Author: retailcoder

Rubberduck.Core/UI/About/AboutControlViewModel.cs

@@ -13,10 +13,12 @@ namespace Rubberduck.UI.About
     public class AboutControlViewModel
     {
         private readonly IVersionCheck _version;
+        private readonly IWebNavigator _web;
 
-        public AboutControlViewModel(IVersionCheck version)
+        public AboutControlViewModel(IVersionCheck version, IWebNavigator web)
         {
             _version = version;
+            _web = web;
 
             UriCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteUri);
             ViewLogCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteViewLog);
@@ -42,10 +44,7 @@ public AboutControlViewModel(IVersionCheck version)
 
         public CommandBase ViewLogCommand { get; }
 
-        private void ExecuteUri(object parameter)
-        {
-            Process.Start(new ProcessStartInfo(((Uri)parameter).AbsoluteUri));
-        }
+        private void ExecuteUri(object parameter) => _web.Navigate(((Uri)parameter));
 
         private void ExecuteViewLog(object parameter)
         {

Rubberduck.Core/UI/About/AboutDialog.cs

@@ -5,9 +5,9 @@ namespace Rubberduck.UI.About
 {
     public partial class AboutDialog : Form
     {
-        public AboutDialog(IVersionCheck versionCheck) : this()
+        public AboutDialog(IVersionCheck versionCheck, IWebNavigator web) : this()
         {
-            ViewModel = new AboutControlViewModel(versionCheck);
+            ViewModel = new AboutControlViewModel(versionCheck, web);
         }
 
         public AboutDialog()

Rubberduck.Core/UI/Command/AboutCommand.cs

@@ -10,16 +10,18 @@ namespace Rubberduck.UI.Command
     [ComVisible(false)]
     public class AboutCommand : CommandBase
     {
-        public AboutCommand(IVersionCheck versionService)
+        public AboutCommand(IVersionCheck versionService, IWebNavigator web)
         {
             _versionService = versionService;
+            _web = web;
         }
 
         private readonly IVersionCheck _versionService;
+        private readonly IWebNavigator _web;
 
         protected override void OnExecute(object parameter)
         {
-            using (var window = new AboutDialog(_versionService))
+            using (var window = new AboutDialog(_versionService, _web))
             {
                 window.ShowDialog();
             }

Rubberduck.Core/UI/Inspections/InspectionResultsViewModel.cs

@@ -89,6 +89,7 @@ public QuickFixCommandViewModel(
 
     public sealed class InspectionResultsViewModel : ViewModelBase, INavigateSelection, IComparer<IInspectionResult>, IComparer, IDisposable
     {
+        private readonly IWebNavigator _web;
         private readonly RubberduckParserState _state;
         private readonly IInspector _inspector;
         private readonly IQuickFixProvider _quickFixProvider;
@@ -106,10 +107,12 @@ public InspectionResultsViewModel(
             INavigateCommand navigateCommand, 
             ReparseCommand reparseCommand,
             IClipboardWriter clipboard,
+            IWebNavigator web,
             IConfigurationService<Configuration> configService,
             ISettingsFormFactory settingsFormFactory,
             IUiDispatcher uiDispatcher)
         {
+            _web = web;
             _state = state;
             _inspector = inspector;
             _quickFixProvider = quickFixProvider;
@@ -771,11 +774,13 @@ public bool CanDisableInspection
             }
         }
 
-        public string InspectionDetailsUrl => _selectedInspection == null 
-            ? "https://rubberduckvba.com/inspections"
-            : $"https://rubberduckvba.com/inspections/details/{_selectedInspection.AnnotationName}";
+        private static readonly Uri _inspectionsHomeUrl = new Uri("https://rubberduckvba.com/inspections");
 
-        private void ExecuteOpenInspectionDetailsPageCommand(object parameter) => Process.Start(new ProcessStartInfo(InspectionDetailsUrl));
+        public Uri InspectionDetailsUrl => _selectedInspection == null 
+            ? _inspectionsHomeUrl 
+            : new Uri($"https://rubberduckvba.com/inspections/details/{_selectedInspection.AnnotationName}");
+
+        private void ExecuteOpenInspectionDetailsPageCommand(object parameter) => _web.Navigate(InspectionDetailsUrl);
 
         private static readonly List<(string Name, hAlignment alignment)> ResultColumns = new List<(string Name, hAlignment alignment)>
         {

Rubberduck.Core/UI/WebNavigator.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Diagnostics;
+
+namespace Rubberduck.UI
+{
+    public interface IWebNavigator
+    {
+        /// <summary>
+        /// Opens the specified URI in the default browser.
+        /// </summary>
+        void Navigate(Uri uri);
+    }
+
+    public class WebNavigator : IWebNavigator
+    {
+        public void Navigate(Uri uri)
+        {
+            Process.Start(new ProcessStartInfo(uri.AbsoluteUri));
+        }
+    }
+}