Improve performance in ImplicitByRefParameter inspection to make the inspections load fast(er)

Author: Hosch250

RetailCoder.VBE/Inspections/ImplicitByRefParameterInspection.cs

@@ -21,16 +21,17 @@ public ImplicitByRefParameterInspection(RubberduckParserState state)
 
         public override IEnumerable<InspectionResultBase> GetInspectionResults()
         {
-            var interfaceMembers = UserDeclarations.FindInterfaceImplementationMembers();
+            var interfaceMembersScope = UserDeclarations.FindInterfaceImplementationMembers().Select(m => m.Scope);
+            var builtinEventHandlers = State.AllDeclarations.FindBuiltInEventHandlers();
 
             var issues = (from item in UserDeclarations
                 where
                     !item.IsInspectionDisabled(AnnotationName)
                     && item.DeclarationType == DeclarationType.Parameter
                     // ParamArray parameters do not allow an explicit "ByRef" parameter mechanism.               
                     && !((ParameterDeclaration)item).IsParamArray
-                    && !interfaceMembers.Select(m => m.Scope).Contains(item.ParentScope)
-                    && !State.AllDeclarations.FindBuiltInEventHandlers().Contains(item.ParentDeclaration)
+                    && !interfaceMembersScope.Contains(item.ParentScope)
+                    && !builtinEventHandlers.Contains(item.ParentDeclaration)
                 let arg = item.Context as VBAParser.ArgContext
                 where arg != null && arg.BYREF() == null && arg.BYVAL() == null
                 select new QualifiedContext<VBAParser.ArgContext>(item.QualifiedName, arg))

RetailCoder.VBE/UI/Inspections/InspectionResultsViewModel.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.Diagnostics;
 using System.Globalization;
 using System.IO;
 using System.Linq;
@@ -260,6 +261,7 @@ private void _state_StateChanged(object sender, EventArgs e)
 
         private async void RefreshInspections()
         {
+            var stopwatch = Stopwatch.StartNew();
             IsBusy = true;
 
             var results = (await _inspector.FindIssuesAsync(_state, CancellationToken.None)).ToList();
@@ -289,6 +291,9 @@ private async void RefreshInspections()
                 IsBusy = false;
                 SelectedItem = null;
             });
+
+            stopwatch.Stop();
+            LogManager.GetCurrentClassLogger().Trace("Inspections loaded in {0}ms", stopwatch.ElapsedMilliseconds);
         }
 
         private void ExecuteQuickFixes(IEnumerable<CodeInspectionQuickFix> quickFixes)