#1051 (English only)

Author: Hosch250

RetailCoder.VBE/UI/Command/MenuItems/AddTestMethodCommandMenuItem.cs

@@ -12,7 +12,7 @@ public AddTestMethodCommandMenuItem(CommandBase command)
         {
         }
 
-        public override string Key { get { return "TestExplorer_AddTestMethod"; } }
+        public override string Key { get { return "TestExplorerMenu_AddTestMethod"; } }
         public override int DisplayOrder { get { return (int)UnitTestingMenuItemDisplayOrder.AddTestMethod; } }
 
         public override Image Image { get { return Resources.flask; } }

RetailCoder.VBE/UI/Command/MenuItems/AddTestMethodExpectedErrorCommandMenuItem.cs

@@ -12,7 +12,7 @@ public AddTestMethodExpectedErrorCommandMenuItem(CommandBase command)
         {
         }
 
-        public override string Key { get { return "TestExplorer_AddExpectedErrorTestMethod"; } }
+        public override string Key { get { return "TestExplorerMenu_AddExpectedErrorTestMethod"; } }
         public override int DisplayOrder { get { return (int)UnitTestingMenuItemDisplayOrder.AddTestMethodExpectedError; } }
 
         public override Image Image { get { return Resources.flask_exclamation; } }

RetailCoder.VBE/UI/Command/MenuItems/AddTestModuleCommandMenuItem.cs

@@ -10,7 +10,7 @@ public AddTestModuleCommandMenuItem(CommandBase command)
         {
         }
 
-        public override string Key { get { return "TestExplorer_AddTestModule"; } }
+        public override string Key { get { return "TestExplorerMenu_AddTestModule"; } }
         public override int DisplayOrder { get { return (int)UnitTestingMenuItemDisplayOrder.AddTestModule; } }
         public override bool BeginGroup { get { return true; } }
     }

RetailCoder.VBE/UI/Command/MenuItems/ParentMenus/ParentMenuItemBase.cs

@@ -31,7 +31,7 @@ protected ParentMenuItemBase(string key, IEnumerable<IMenuItem> items, int? befo
 
         public string Key { get { return Item == null ? null : Item.Tag; } }
 
-        public Func<string> Caption { get { return () => Key == null ? null : RubberduckUI.ResourceManager.GetString(Key, UI.Settings.Settings.Culture); } }
+        public Func<string> Caption { get { return () => Key == null ? null : RubberduckUI.ResourceManager.GetString(Key, Settings.Settings.Culture); } }
 
         public virtual bool BeginGroup { get { return false; } }
         public virtual int DisplayOrder { get { return default(int); } }

RetailCoder.VBE/UI/RubberduckUI.Designer.cs

@@ -982,19 +982,19 @@ Are you sure you want to proceed with this rename?</value>
     <value>Find symbol</value>
   </data>
   <data name="IndentCurrentModule" xml:space="preserve">
-    <value>Current module</value>
+    <value>Current &amp;Module</value>
   </data>
   <data name="IndentCurrentProcedure" xml:space="preserve">
-    <value>Current procedure</value>
+    <value>Current &amp;Procedure</value>
   </data>
   <data name="IndentCurrentProject" xml:space="preserve">
     <value>Entire project</value>
   </data>
   <data name="SmartIndenterMenu" xml:space="preserve">
-    <value>Indent</value>
+    <value>In&amp;dent</value>
   </data>
   <data name="RefactorMenu_IntroduceParameter" xml:space="preserve">
-    <value>&amp;Introduce Parameter</value>
+    <value>Introduce &amp;Parameter</value>
   </data>
   <data name="RefactorMenu_IntroduceField" xml:space="preserve">
     <value>Introduce &amp;Field</value>
@@ -1058,7 +1058,7 @@ Are you sure you want to proceed with this rename?</value>
     <value>E&amp;xtract Interface</value>
   </data>
   <data name="RefactorMenu_ImplementInterface" xml:space="preserve">
-    <value>Implement Interface</value>
+    <value>&amp;Implement Interface</value>
   </data>
   <data name="ImplementInterface_Caption" xml:space="preserve">
     <value>Rubberduck - Implement Interface</value>
@@ -1551,7 +1551,7 @@ All our stargazers, likers &amp; followers, for the warm fuzzies
     <value>Source Control - Undo</value>
   </data>
   <data name="NoIndentAnnotation" xml:space="preserve">
-    <value>Add '@NoIndent</value>
+    <value>&amp;Add '@NoIndent</value>
   </data>
   <data name="CodeExplorer_Sort" xml:space="preserve">
     <value>Sort</value>
@@ -1721,4 +1721,13 @@ All our stargazers, likers &amp; followers, for the warm fuzzies
   <data name="RubberduckFatalError" xml:space="preserve">
     <value>Rubberduck encountered an error. Please save your work and restart the host program, then upload your log file to our GitHub page.</value>
   </data>
+  <data name="TestExplorerMenu_AddExpectedErrorTestMethod" xml:space="preserve">
+    <value>Test Method (&amp;Expected Error)</value>
+  </data>
+  <data name="TestExplorerMenu_AddTestMethod" xml:space="preserve">
+    <value>Test &amp;Method</value>
+  </data>
+  <data name="TestExplorerMenu_AddTestModule" xml:space="preserve">
+    <value>Test M&amp;odule</value>
+  </data>
 </root>

RetailCoder.VBE/UI/RubberduckUI.resx

@@ -65,6 +65,8 @@ private void ReparseRequested(object sender, ParseRequestEventArgs e)
                 Cancel(e.Component);
                 Task.Run(() =>
                 {
+                    State.SetModuleState(e.Component, ParserState.Pending);
+
                     SyncComReferences(State.Projects);
                     AddBuiltInDeclarations();
 
@@ -490,7 +492,6 @@ private void UnloadComReference(Reference reference, IReadOnlyList<VBProject> pr
         private Task ParseAsync(VBComponent component, CancellationToken token, TokenStreamRewriter rewriter = null)
         {
             State.ClearStateCache(component);
-            State.SetModuleState(component, ParserState.Pending); // also clears module-exceptions
 
             var linkedTokenSource = CancellationTokenSource.CreateLinkedTokenSource(_central.Token, token);
 

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -922,36 +922,6 @@ public bool IsDirty()
             return false;
         }
 
-        public bool HasAllParseTrees(IReadOnlyList<VBComponent> expected)
-        {
-            var expectedModules = new List<QualifiedModuleName>();
-            foreach (var component in expected)
-            {
-                expectedModules.Add(new QualifiedModuleName(component));
-            }
-
-            foreach (var key in _moduleStates.Keys)
-            {
-                if (key.Component == null || expectedModules.Contains(key))
-                {
-                    continue;
-                }
-
-                ClearStateCache(key.Component);
-            }
-
-            var parseTreeCount = 0;
-            foreach (var state in _moduleStates)
-            {
-                if (state.Value.ParseTree != null)
-                {
-                    parseTreeCount++;
-                }
-            }
-
-            return parseTreeCount == expected.Count;
-        }
-
         public TokenStreamRewriter GetRewriter(VBComponent component)
         {
             return new TokenStreamRewriter(_moduleStates[new QualifiedModuleName(component)].TokenStream);