fix MissingArgumentContext case

retailcoder · retailcoder · commit 2d25779eeca3 · 2025-01-20T10:25:30.000-05:00
diff --git a/Rubberduck.CodeAnalysis/Inspections/Concrete/ParameterlessCellsInspection.cs b/Rubberduck.CodeAnalysis/Inspections/Concrete/ParameterlessCellsInspection.cs
@@ -80,9 +80,9 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults(Declara
         protected override bool IsResultReference(IdentifierReference reference, DeclarationFinder finder)
         {
             var memberAccess = reference.Context.GetAncestor<VBAParser.MemberAccessExprContext>();
-            var memberArgs = memberAccess?.GetAncestor<VBAParser.IndexExprContext>()?.argumentList()?.argument();
+            var memberArgs = memberAccess?.GetAncestor<VBAParser.IndexExprContext>()?.argumentList();
 
-            return memberAccess is VBAParser.MemberAccessExprContext && (memberArgs?.Length ?? 0) == 0;
+            return memberAccess != null && !memberArgs.GetDescendents<VBAParser.ArgumentExpressionContext>().Any();
         }
 
         protected override string ResultDescription(IdentifierReference reference)

Original file line number	Diff line number	Diff line change
`@@ -80,9 +80,9 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults(Declara`
`80`	`80`	`protected override bool IsResultReference(IdentifierReference reference, DeclarationFinder finder)`
`81`	`81`	`{`
`82`	`82`	`var memberAccess = reference.Context.GetAncestor<VBAParser.MemberAccessExprContext>();`
`83`		`- var memberArgs = memberAccess?.GetAncestor<VBAParser.IndexExprContext>()?.argumentList()?.argument();`
	`83`	`+ var memberArgs = memberAccess?.GetAncestor<VBAParser.IndexExprContext>()?.argumentList();`
`84`	`84`
`85`		`- return memberAccess is VBAParser.MemberAccessExprContext && (memberArgs?.Length ?? 0) == 0;`
	`85`	`+ return memberAccess != null && !memberArgs.GetDescendents<VBAParser.ArgumentExpressionContext>().Any();`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`protected override string ResultDescription(IdentifierReference reference)`