Remove the useless metrics

Signed-off-by: Joe Adams <github@joeadams.io>

Author: sysadmind

collector/nodes.go

@@ -174,9 +174,6 @@ type Nodes struct {
 	all    bool
 	node   string
 
-	up                              prometheus.Gauge
-	totalScrapes, jsonParseFailures prometheus.Counter
-
 	nodeMetrics               []*nodeMetric
 	gcCollectionMetrics       []*gcCollectionMetric
 	breakerMetrics            []*breakerMetric
@@ -195,19 +192,6 @@ func NewNodes(logger log.Logger, client *http.Client, url *url.URL, all bool, no
 		all:    all,
 		node:   node,
 
-		up: prometheus.NewGauge(prometheus.GaugeOpts{
-			Name: prometheus.BuildFQName(namespace, "node_stats", "up"),
-			Help: "Was the last scrape of the Elasticsearch nodes endpoint successful.",
-		}),
-		totalScrapes: prometheus.NewCounter(prometheus.CounterOpts{
-			Name: prometheus.BuildFQName(namespace, "node_stats", "total_scrapes"),
-			Help: "Current total Elasticsearch node scrapes.",
-		}),
-		jsonParseFailures: prometheus.NewCounter(prometheus.CounterOpts{
-			Name: prometheus.BuildFQName(namespace, "node_stats", "json_parse_failures"),
-			Help: "Number of errors while parsing JSON.",
-		}),
-
 		nodeMetrics: []*nodeMetric{
 			{
 				Type: prometheus.GaugeValue,
@@ -1869,9 +1853,6 @@ func (c *Nodes) Describe(ch chan<- *prometheus.Desc) {
 	for _, metric := range c.filesystemIODeviceMetrics {
 		ch <- metric.Desc
 	}
-	ch <- c.up.Desc()
-	ch <- c.totalScrapes.Desc()
-	ch <- c.jsonParseFailures.Desc()
 }
 
 func (c *Nodes) fetchAndDecodeNodeStats() (nodeStatsResponse, error) {
@@ -1907,36 +1888,25 @@ func (c *Nodes) fetchAndDecodeNodeStats() (nodeStatsResponse, error) {
 
 	bts, err := io.ReadAll(res.Body)
 	if err != nil {
-		c.jsonParseFailures.Inc()
 		return nsr, err
 	}
 
 	if err := json.Unmarshal(bts, &nsr); err != nil {
-		c.jsonParseFailures.Inc()
 		return nsr, err
 	}
 	return nsr, nil
 }
 
 // Collect gets nodes metric values
 func (c *Nodes) Collect(ch chan<- prometheus.Metric) {
-	c.totalScrapes.Inc()
-	defer func() {
-		ch <- c.up
-		ch <- c.totalScrapes
-		ch <- c.jsonParseFailures
-	}()
-
 	nodeStatsResp, err := c.fetchAndDecodeNodeStats()
 	if err != nil {
-		c.up.Set(0)
 		level.Warn(c.logger).Log(
 			"msg", "failed to fetch and decode node stats",
 			"err", err,
 		)
 		return
 	}
-	c.up.Set(1)
 
 	for _, node := range nodeStatsResp.Nodes {
 		// Handle the node labels metric

collector/nodes_test.go

@@ -338,15 +338,6 @@ func TestNodesStats(t *testing.T) {
             # HELP elasticsearch_jvm_uptime_seconds JVM process uptime in seconds
             # TYPE elasticsearch_jvm_uptime_seconds gauge
             elasticsearch_jvm_uptime_seconds{cluster="elasticsearch",es_client_node="true",es_data_node="true",es_ingest_node="true",es_master_node="true",host="127.0.0.1",name="bVrN1Hx",type="mapped"} 14.845
-            # HELP elasticsearch_node_stats_json_parse_failures Number of errors while parsing JSON.
-            # TYPE elasticsearch_node_stats_json_parse_failures counter
-            elasticsearch_node_stats_json_parse_failures 0
-            # HELP elasticsearch_node_stats_total_scrapes Current total Elasticsearch node scrapes.
-            # TYPE elasticsearch_node_stats_total_scrapes counter
-            elasticsearch_node_stats_total_scrapes 1
-            # HELP elasticsearch_node_stats_up Was the last scrape of the Elasticsearch nodes endpoint successful.
-            # TYPE elasticsearch_node_stats_up gauge
-            elasticsearch_node_stats_up 1
             # HELP elasticsearch_nodes_roles Node roles
             # TYPE elasticsearch_nodes_roles gauge
             elasticsearch_nodes_roles{cluster="elasticsearch",host="127.0.0.1",name="bVrN1Hx",role="client"} 1
@@ -806,15 +797,6 @@ func TestNodesStats(t *testing.T) {
              # HELP elasticsearch_jvm_uptime_seconds JVM process uptime in seconds
              # TYPE elasticsearch_jvm_uptime_seconds gauge
              elasticsearch_jvm_uptime_seconds{cluster="elasticsearch",es_client_node="true",es_data_node="true",es_ingest_node="true",es_master_node="true",host="172.17.0.2",name="9_P7yui",type="mapped"} 16.456
-             # HELP elasticsearch_node_stats_json_parse_failures Number of errors while parsing JSON.
-             # TYPE elasticsearch_node_stats_json_parse_failures counter
-             elasticsearch_node_stats_json_parse_failures 0
-             # HELP elasticsearch_node_stats_total_scrapes Current total Elasticsearch node scrapes.
-             # TYPE elasticsearch_node_stats_total_scrapes counter
-             elasticsearch_node_stats_total_scrapes 1
-             # HELP elasticsearch_node_stats_up Was the last scrape of the Elasticsearch nodes endpoint successful.
-             # TYPE elasticsearch_node_stats_up gauge
-             elasticsearch_node_stats_up 1
              # HELP elasticsearch_nodes_roles Node roles
              # TYPE elasticsearch_nodes_roles gauge
              elasticsearch_nodes_roles{cluster="elasticsearch",host="172.17.0.2",name="9_P7yui",role="client"} 1
@@ -1338,15 +1320,6 @@ func TestNodesStats(t *testing.T) {
              # HELP elasticsearch_jvm_uptime_seconds JVM process uptime in seconds
              # TYPE elasticsearch_jvm_uptime_seconds gauge
              elasticsearch_jvm_uptime_seconds{cluster="elasticsearch",es_client_node="true",es_data_node="true",es_ingest_node="true",es_master_node="true",host="172.17.0.2",name="aaf5a8a0bceb",type="mapped"} 21.844
-             # HELP elasticsearch_node_stats_json_parse_failures Number of errors while parsing JSON.
-             # TYPE elasticsearch_node_stats_json_parse_failures counter
-             elasticsearch_node_stats_json_parse_failures 0
-             # HELP elasticsearch_node_stats_total_scrapes Current total Elasticsearch node scrapes.
-             # TYPE elasticsearch_node_stats_total_scrapes counter
-             elasticsearch_node_stats_total_scrapes 1
-             # HELP elasticsearch_node_stats_up Was the last scrape of the Elasticsearch nodes endpoint successful.
-             # TYPE elasticsearch_node_stats_up gauge
-             elasticsearch_node_stats_up 1
              # HELP elasticsearch_nodes_roles Node roles
              # TYPE elasticsearch_nodes_roles gauge
              elasticsearch_nodes_roles{cluster="elasticsearch",host="172.17.0.2",name="aaf5a8a0bceb",role="client"} 1