Refactor code formatting and error handling

Removed unnecessary blank lines and improved code formatting across multiple files for consistency. Updated error handling in ActorReadLogRecordsJSON and ActorReadSynchronizeConfigurationJSON to suppress unwanted error propagation messages. Adjusted indentation and parameter alignment in several SwiftUI views for better readability.

Author: rsyncOSX

RsyncUI/Model/Execution/EstimateExecute/Estimate.swift

@@ -10,15 +10,13 @@ import OSLog
 import ParseRsyncOutput
 import RsyncProcess
 
-
 @MainActor
 final class Estimate {
     private var localconfigurations: [SynchronizeConfiguration]
     private var structprofile: String?
 
     weak var localprogressdetails: ProgressDetails?
 
-    
     var stackoftasks: [Int]?
     var synchronizeIDwitherror: String = ""
 
@@ -65,7 +63,6 @@ final class Estimate {
         }
     }
 
-    
     // Used in Estimate
     private func validatetagging(_ lines: Int, _ tagged: Bool) throws {
         if lines > SharedReference.shared.alerttagginglines, tagged == false {
@@ -90,11 +87,10 @@ final class Estimate {
          selecteduuids: Set<UUID>,
          progressdetails: ProgressDetails?)
     {
-        
         structprofile = profile
         localconfigurations = configurations
         localprogressdetails = progressdetails
-        
+
         stackoftasks = computestackoftasks(selecteduuids)
         localprogressdetails?.setprofileandnumberofconfigurations(structprofile, stackoftasks?.count ?? 0)
         Logger.process.debugmessageonly("Estimate: START ESTIMATION")

RsyncUI/Model/Execution/EstimateExecute/Execute.swift

@@ -134,13 +134,12 @@ final class Execute {
          filehandler: @escaping (Int) -> Void,
          updateconfigurations: @escaping ([SynchronizeConfiguration]) -> Void)
     {
-        
         structprofile = profile
         localconfigurations = configurations
         localprogressdetails = progressdetails
         localfilehandler = filehandler
         localupdateconfigurations = updateconfigurations
-        
+
         guard selecteduuids.count > 0 else { return }
         let taskstosynchronize = localconfigurations.filter {
             selecteduuids.contains($0.id) && $0.task != SharedReference.shared.halted
@@ -149,7 +148,6 @@ final class Execute {
         guard stackoftasks?.count ?? 0 > 0 else { return }
         Logger.process.debugmessageonly("Execute: START EXECUTION")
         startexecution()
-
     }
 
     @discardableResult
@@ -177,7 +175,6 @@ final class Execute {
 }
 
 extension Execute {
-
     private func processtermination(stringoutputfromrsync: [String]?, _ hiddenID: Int?) {
         guard setabort == false else { return }
         // Log records
@@ -187,11 +184,11 @@ extension Execute {
         // Prepareoutput prepares output from rsync for extracting the numbers only.
         // It removes all lines except the last 20 lines where summarized numbers are put
         let preparedoutputfromrsync = PrepareOutputFromRsync().prepareOutputFromRsync(stringoutputfromrsync)
-        
+
         if SharedReference.shared.addsummarylogrecord {
             do {
                 let stats = try ParseRsyncOutput(preparedoutputfromrsync,
-                                                SharedReference.shared.rsyncversion3 ? .ver3 : .openrsync).getstats()
+                                                 SharedReference.shared.rsyncversion3 ? .ver3 : .openrsync).getstats()
                 if let logData = (hiddenID ?? -1, stats) as? Typelogdata {
                     schedulerecords.append(logData)
                 }
@@ -205,14 +202,14 @@ extension Execute {
                 Logger.process.debugmessageonly("Execute: getstats() FAILED")
             }
         }
-        
+
         guard stackoftasks?.count ?? 0 > 0 else {
             let update = Logging(profile: structprofile,
                                  configurations: localconfigurations)
             let updateconfigurations = update.setCurrentDateonConfiguration(configrecords: configrecords)
             // Send date stamped configurations back to caller
             localupdateconfigurations(updateconfigurations)
-            
+
             Logger.process.debugmessageonly("Execute: EXECUTION is completed")
             guard SharedReference.shared.addsummarylogrecord else { return }
             // Update logrecords
@@ -246,7 +243,7 @@ extension Execute {
                     localnoestprogressdetails?.appenduuidwithdatatosynchronize(config.id)
                 }
             }
-            
+
             guard stackoftasks?.count ?? 0 > 0 else {
                 let update = Logging(profile: structprofile,
                                      configurations: localconfigurations)

RsyncUI/Model/Execution/EstimateExecute/RemoteDataNumbers.swift

@@ -8,8 +8,8 @@
 // swiftlint:disable line_length
 
 import Foundation
-import ParseRsyncOutput
 import OSLog
+import ParseRsyncOutput
 
 @MainActor
 struct RemoteDataNumbers: Identifiable, Hashable {
@@ -49,7 +49,7 @@ struct RemoteDataNumbers: Identifiable, Hashable {
     var stats: String?
     // A reduced number of output
     var preparedoutputfromrsync: [String]?
-    
+
     init(stringoutputfromrsync: [String]?,
          config: SynchronizeConfiguration?)
     {
@@ -99,11 +99,11 @@ struct RemoteDataNumbers: Identifiable, Hashable {
                 totalnumbers = "0"
 
                 datatosynchronize = false
-                
+
                 Logger.process.debugmessageonly("RemoteDataNumbers: getstats() FAILED")
                 return
             }
-            
+
             filestransferred = parsersyncoutput.formatted_filestransferred
 
             filestransferred_Int = parsersyncoutput.numbersonly?.filestransferred ?? 0
@@ -132,8 +132,6 @@ struct RemoteDataNumbers: Identifiable, Hashable {
             }
         }
     }
-    
-    
 }
 
 // swiftlint:enable line_length

RsyncUI/Model/Global/AlertError.swift

@@ -16,7 +16,7 @@ final class AlertError {
     func alert(error: Error) {
         activeError = error
     }
-    
+
     func clearError() {
         activeError = nil
     }

RsyncUI/Model/Storage/Actors/ActorReadLogRecordsJSON.swift

@@ -37,12 +37,17 @@ actor ActorReadLogRecordsJSON {
                 let item = LogRecords(element)
                 return validhiddenIDs.contains(item.hiddenID) ? item : nil
             }
-
-        } catch let e {
+        } catch {
             Logger.process.error("ActorReadLogRecordsJSON - \(profile ?? "default profile", privacy: .public): some ERROR reading logrecords from permanent storage")
-            let error = e
-            await path.propagateError(error: error)
         }
+        /*
+           I do not wish to receive that annoying message.
+         } catch let e {
+             Logger.process.error("ActorReadLogRecordsJSON - \(profile ?? "default profile", privacy: .public): some ERROR reading logrecords from permanent storage")
+             let error = e
+             await path.propagateError(error: error)
+         }
+         */
         return nil
     }
 

RsyncUI/Model/Storage/Actors/ActorReadSynchronizeConfigurationJSON.swift

@@ -92,11 +92,17 @@ actor ActorReadSynchronizeConfigurationJSON {
 
             return tasks
 
-        } catch let e {
+        } catch {
             Logger.process.error("ActorReadSynchronizeConfigurationJSON - \(profile ?? "default profile", privacy: .public): some ERROR reading synchronize configurations from permanent storage")
-            let error = e
-            await path.propagateError(error: error)
         }
+        /*
+          I do not wish to receive that annoying message.
+         } catch let e {
+             Logger.process.error("ActorReadSynchronizeConfigurationJSON - \(profile ?? "default profile", privacy: .public): some ERROR reading synchronize configurations from permanent storage")
+             let error = e
+             await path.propagateError(error: error)
+         }
+          */
         return nil
     }
 

RsyncUI/Views/Detailsview/EstimationInProgressView.swift

@@ -47,11 +47,11 @@ struct EstimationInProgressView: View {
             .onAppear {
                 // Either is there some selceted tasks or if not
                 // the EstimateTasks selects all tasks to be estimated
-                
+
                 Estimate(profile: profile,
-                                configurations: configurations,
-                                selecteduuids: selecteduuids,
-                                progressdetails: progressdetails)
+                         configurations: configurations,
+                         selecteduuids: selecteduuids,
+                         progressdetails: progressdetails)
             }
             .progressViewStyle(.circular)
     }
@@ -62,9 +62,9 @@ struct EstimationInProgressView: View {
                 // Either is there some selceted tasks or if not
                 // the EstimateTasks selects all tasks to be estimated
                 Estimate(profile: profile,
-                                configurations: configurations,
-                                selecteduuids: selecteduuids,
-                                progressdetails: progressdetails)
+                         configurations: configurations,
+                         selecteduuids: selecteduuids,
+                         progressdetails: progressdetails)
             }
     }
 

RsyncUI/Views/LogView/LogfileView.swift

@@ -74,7 +74,6 @@ struct LogfileView: View {
             }
         }
     }
-
 }
 
 struct LogfileRecords: Identifiable {

RsyncUI/Views/ProgressView/SynchronizeProgressView.swift

@@ -21,9 +21,8 @@ struct SynchronizeProgressView: View {
                         Color.gray.opacity(0.2),
                         lineWidth: 12
                     )
-                
+
                 if max > 0 {
-                
                     Circle()
                         .trim(from: 0, to: min(progress / max, 1.0))
                         .stroke(
@@ -40,7 +39,7 @@ struct SynchronizeProgressView: View {
                         .rotationEffect(.degrees(-90))
                         .animation(.spring(response: 0.6, dampingFraction: 0.8), value: progress)
                 }
-                
+
                 VStack(spacing: 4) {
                     Text("\(Int(progress))")
                         .font(.system(size: 36, weight: .bold, design: .rounded))
@@ -57,4 +56,3 @@ struct SynchronizeProgressView: View {
         .animation(.default, value: progress)
     }
 }
-

RsyncUI/Views/Restore/RestoreTableView.swift

@@ -75,7 +75,7 @@ struct RestoreTableView: View {
                     }
 
                     if gettingfilelist { ProgressView() }
-                    if restore.restorefilesinprogress {SynchronizeProgressView(max: restore.max, progress: restore.progress, statusText: "Restoring...") }
+                    if restore.restorefilesinprogress { SynchronizeProgressView(max: restore.max, progress: restore.progress, statusText: "Restoring...") }
 
                     if restore.selectedconfig?.offsiteServer.isEmpty == true {
                         DismissafterMessageView(dismissafter: 2, mytext: NSLocalizedString("Use macOS Finder to restore files from attached discs.", comment: ""))
@@ -343,4 +343,3 @@ extension RestoreTableView {
 }
 
 // swiftlint:enable line_length
-