Skip to content

Commit 90dd709

Browse files
committed
Remove convenience init from EstimateExecute
Eliminated the convenience initializer for estimation in EstimateExecute and updated EstimationInProgressView to use the main initializer directly. This simplifies initialization and reduces redundancy.
1 parent 592ac1a commit 90dd709

File tree

2 files changed

+10
-21
lines changed

2 files changed

+10
-21
lines changed

RsyncUI/Model/Execution/EstimateExecute/EstimateExecute.swift

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ final class EstimateExecute {
175175
}
176176
}
177177

178-
// EXECUTE init
178+
// ESTIMATE and EXECUTE init
179179
@discardableResult
180180
init(profile: String?,
181181
configurations: [SynchronizeConfiguration],
@@ -239,24 +239,6 @@ final class EstimateExecute {
239239
startexecution_noestimate()
240240
}
241241

242-
// Convenience init for start estimation
243-
@discardableResult
244-
convenience init(profile: String?,
245-
configurations: [SynchronizeConfiguration],
246-
selecteduuids: Set<UUID>,
247-
progressdetails: ProgressDetails?)
248-
{
249-
let filehandler: (Int) -> Void = { _ in }
250-
let updateconfigurations: ([SynchronizeConfiguration]) -> Void = { _ in }
251-
self.init(profile: profile,
252-
configurations: configurations,
253-
selecteduuids: selecteduuids,
254-
progressdetails: progressdetails,
255-
filehandler: filehandler,
256-
updateconfigurations: updateconfigurations,
257-
mode: .estimate)
258-
}
259-
260242
deinit {
261243
Logger.process.debugmessageonly("EstimateExecute: DEINIT")
262244
self.stackoftasks = nil

RsyncUI/Views/Detailsview/EstimationInProgressView.swift

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,14 @@ struct EstimationInProgressView: View {
4747
.onAppear {
4848
// Either is there some selceted tasks or if not
4949
// the EstimateTasks selects all tasks to be estimated
50+
5051
EstimateExecute(profile: profile,
5152
configurations: configurations,
5253
selecteduuids: selecteduuids,
53-
progressdetails: progressdetails)
54+
progressdetails: progressdetails,
55+
filehandler: { _ in },
56+
updateconfigurations: { _ in },
57+
mode: .estimate)
5458
}
5559
.progressViewStyle(.circular)
5660
}
@@ -63,7 +67,10 @@ struct EstimationInProgressView: View {
6367
EstimateExecute(profile: profile,
6468
configurations: configurations,
6569
selecteduuids: selecteduuids,
66-
progressdetails: progressdetails)
70+
progressdetails: progressdetails,
71+
filehandler: { _ in },
72+
updateconfigurations: { _ in },
73+
mode: .estimate)
6774
}
6875
}
6976

0 commit comments

Comments
 (0)