From 5dc7e81b6464cc94791ac19f5a5a5a534c947a85 Mon Sep 17 00:00:00 2001 From: "robin.bygrave" Date: Tue, 10 Dec 2024 13:21:20 +1300 Subject: [PATCH] Make extras classes final, not intended for extension We can make these classes final with the view that they are not intended to be extended. --- src/main/java/robaho/net/httpserver/extras/ContentEncoding.java | 2 +- src/main/java/robaho/net/httpserver/extras/FormParser.java | 2 +- .../java/robaho/net/httpserver/extras/MultipartFormParser.java | 2 +- src/main/java/robaho/net/httpserver/extras/QueryParameters.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/robaho/net/httpserver/extras/ContentEncoding.java b/src/main/java/robaho/net/httpserver/extras/ContentEncoding.java index 9ee2eb1..9dcd655 100644 --- a/src/main/java/robaho/net/httpserver/extras/ContentEncoding.java +++ b/src/main/java/robaho/net/httpserver/extras/ContentEncoding.java @@ -5,7 +5,7 @@ import com.sun.net.httpserver.Headers; -public class ContentEncoding { +public final class ContentEncoding { private static final String defaultCharset = StandardCharsets.ISO_8859_1.name(); diff --git a/src/main/java/robaho/net/httpserver/extras/FormParser.java b/src/main/java/robaho/net/httpserver/extras/FormParser.java index c55e64e..752a9db 100644 --- a/src/main/java/robaho/net/httpserver/extras/FormParser.java +++ b/src/main/java/robaho/net/httpserver/extras/FormParser.java @@ -14,7 +14,7 @@ /** * Parse url-encoded requests. */ -public class FormParser { +public final class FormParser { // Sets the maximum count of accepted POST params - protection against Hash collision DOS attacks private static final int MAX_PARAMS = Integer.getInteger("robaho.net.httpserver.max_form_params", 1000); // 0 == no limit diff --git a/src/main/java/robaho/net/httpserver/extras/MultipartFormParser.java b/src/main/java/robaho/net/httpserver/extras/MultipartFormParser.java index 8d6f169..e976668 100644 --- a/src/main/java/robaho/net/httpserver/extras/MultipartFormParser.java +++ b/src/main/java/robaho/net/httpserver/extras/MultipartFormParser.java @@ -22,7 +22,7 @@ /** * parse multipart form data */ -public class MultipartFormParser { +public final class MultipartFormParser { /** * a multipart part. * diff --git a/src/main/java/robaho/net/httpserver/extras/QueryParameters.java b/src/main/java/robaho/net/httpserver/extras/QueryParameters.java index 9958916..985edac 100644 --- a/src/main/java/robaho/net/httpserver/extras/QueryParameters.java +++ b/src/main/java/robaho/net/httpserver/extras/QueryParameters.java @@ -6,7 +6,7 @@ import java.util.LinkedList; import java.util.List; -public class QueryParameters extends LinkedHashMap> { +public final class QueryParameters extends LinkedHashMap> { /** * @param encoding a valid java character set name