Fix Psalm, add unit tests

Author: msmakouz

psalm.xml

@@ -4,6 +4,8 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+    findUnusedBaselineEntry="true"
+    findUnusedCode="false"
 >
     <projectFiles>
         <directory name="src"/>

src/RoadRunnerStore.php

@@ -9,7 +9,6 @@
 use Symfony\Component\Lock\BlockingStoreInterface;
 use Symfony\Component\Lock\Exception\LockAcquiringException;
 use Symfony\Component\Lock\Exception\LockConflictedException;
-use Symfony\Component\Lock\Exception\LockReleasingException;
 use Symfony\Component\Lock\Key;
 use Symfony\Component\Lock\SharedLockStoreInterface;
 use Symfony\Component\Lock\Store\ExpiringStoreTrait;
@@ -122,8 +121,8 @@ public function waitAndSave(Key $key): void
         $status = $this->lock->lock($resource, $lockId, $this->initialTtl, $this->initialWaitTtl);
 
         $key->setState(__CLASS__, $lockId);
-        if (!$status) {
-            throw new LockConflictedException();
+        if ($status === false) {
+            throw new LockConflictedException('RoadRunner. Failed to make lock');
         }
 
         $this->checkNotExpired($key);

tests/RoadRunnerStoreTest.php

@@ -161,4 +161,33 @@ public function testDeleteFail(): void
         $key->setState(RoadRunnerStore::class, 'lock-id');
         $store->delete($key);
     }
+
+    public function testWaitAndSaveSuccess(): void
+    {
+        $this->rrLock->expects($this->once())
+            ->method('lock')
+            ->with('resource-name', 'random-id', 300, 60)
+            ->willReturn('lock-id');
+
+        $store = new RoadRunnerStore($this->rrLock, $this->tokens);
+        $key = new Key('resource-name');
+        $store->waitAndSave($key);
+
+        $this->assertTrue($key->hasState(RoadRunnerStore::class));
+        $this->assertSame('random-id', $key->getState(RoadRunnerStore::class));
+    }
+
+    public function testWaitAndSaveFail(): void
+    {
+        $this->expectException(LockConflictedException::class);
+        $this->expectExceptionMessage('RoadRunner. Failed to make lock');
+
+        $this->rrLock->expects($this->once())
+            ->method('lock')
+            ->with('resource-name', 'random-id', 300, 60)
+            ->willReturn(false);
+
+        $store = new RoadRunnerStore($this->rrLock, $this->tokens);
+        $store->waitAndSave(new Key('resource-name'));
+    }
 }