$initialWaitTtl = 0 (sec) by default; 60 - is too big value

Author: gam6itko

composer.json

@@ -34,7 +34,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^10.0",
-        "vimeo/psalm": "^5.9"
+        "vimeo/psalm": "^5.9 || ^6.0"
     },
     "autoload": {
         "psr-4": {

src/RoadRunnerStore.php

@@ -25,15 +25,15 @@ public function __construct(
         private readonly RR\LockInterface $lock,
         private readonly TokenGeneratorInterface $tokens = new RandomTokenGenerator(),
         private readonly float $initialTtl = 300.0,
-        private readonly float $initialWaitTtl = 60,
+        private readonly float $initialWaitTtl = 0,
     ) {
         \assert($this->initialTtl >= 0);
         \assert($this->initialWaitTtl >= 0);
     }
 
-    public function withTtl(float $ttl): self
+    public function withTtl(float $ttl, float $waitTtl = 0): self
     {
-        return new self($this->lock, $this->tokens, $ttl, $this->initialWaitTtl);
+        return new self($this->lock, $this->tokens, $ttl, $waitTtl);
     }
 
     public function save(Key $key): void
@@ -46,7 +46,7 @@ public function save(Key $key): void
             /** @var non-empty-string $resource */
             $resource = (string)$key;
 
-            $status = $this->lock->lock($resource, $lockId, $this->initialTtl);
+            $status = $this->lock->lock($resource, $lockId, $this->initialTtl, $this->initialWaitTtl);
 
             if (false === $status) {
                 throw new LockConflictedException('RoadRunner. Failed to make lock');
@@ -65,7 +65,7 @@ public function saveRead(Key $key): void
 
         /** @var non-empty-string $resource */
         $resource = (string)$key;
-        $status = $this->lock->lockRead($resource, $lockId, $this->initialTtl);
+        $status = $this->lock->lockRead($resource, $lockId, $this->initialTtl, $this->initialWaitTtl);
 
         if (false === $status) {
             throw new LockConflictedException('RoadRunner. Failed to make read lock');

tests/RoadRunnerStoreTest.php

@@ -166,7 +166,7 @@ public function testWaitAndSaveSuccess(): void
     {
         $this->rrLock->expects($this->once())
             ->method('lock')
-            ->with('resource-name', 'random-id', 300, 60)
+            ->with('resource-name', 'random-id', 300, 0)
             ->willReturn('lock-id');
 
         $store = new RoadRunnerStore($this->rrLock, $this->tokens);
@@ -184,7 +184,7 @@ public function testWaitAndSaveFail(): void
 
         $this->rrLock->expects($this->once())
             ->method('lock')
-            ->with('resource-name', 'random-id', 300, 60)
+            ->with('resource-name', 'random-id', 300, 0)
             ->willReturn(false);
 
         $store = new RoadRunnerStore($this->rrLock, $this->tokens);