Skip to content

Commit 1722e7f

Browse files
committed
minor updates in docs
1 parent 91dd23e commit 1722e7f

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

plotoptix/npoptix.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2539,11 +2539,9 @@ def setup_camera(self, name: str,
25392539
to a ~70mm lens in a typical 35mm frame camera).
25402540
camera_matrix : array_like, optional
25412541
Camera intrinsic matrix in OpenCV convention: `[[fx, 0, cx], [0, fy, cy], [0, 0, 1]]`.
2542-
Only `fs`, `fy`, `cx`, `cy` values are used,unit is [mm]; values at positions of constant
2542+
Only `fs`, `fy`, `cx`, `cy` values are used, unit is [mm]; values at positions of constant
25432543
`0`s and `1` are ignored. **Note**: camera matrix parameters override `fov` and require
25442544
`sensor_height` argument.
2545-
# distort_coeffs : array_like, optional
2546-
# Camera distortion coefficients in OpenCV convention: `[k1, k2, p1, p2, k3]`
25472545
sensor_height : float, optional
25482546
Height of the sensor, [mm]. Used only if `camera_matrix` is provided.
25492547
Default `-1` is internally reset to `24.0` (35mm camera film size).
@@ -2666,6 +2664,15 @@ def update_camera(self, name: Optional[str] = None,
26662664
Focus distance / (eye - target).length.
26672665
fov : float, optional
26682666
Field of view in degrees.
2667+
camera_matrix : array_like, optional
2668+
Camera intrinsic matrix in OpenCV convention: `[[fx, 0, cx], [0, fy, cy], [0, 0, 1]]`.
2669+
Only `fs`, `fy`, `cx`, `cy` values are used, unit is [mm]; values at positions of constant
2670+
`0`s and `1` are ignored. **Note**: camera matrix parameters override `fov` and require
2671+
`sensor_height` value (if `sensor_height` is not provided then the previously set value
2672+
is used).
2673+
sensor_height : float, optional
2674+
Height of the sensor, [mm]. Used only if `camera_matrix` is provided.
2675+
Value set previously is not updated if default `-1` is used.
26692676
"""
26702677
name, cam_handle = self.get_camera_name_handle(name)
26712678
if (name is None) or (cam_handle == 0): return

0 commit comments

Comments
 (0)