Merge pull request #214 from rkotze/selected-author-unique

Fix co-author email filtering by exact

Author: rkotze

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 Follows [Semantic Versioning](https://semver.org/).
 
+## git-mob-core 0.10.1
+
+### Fixed
+
+- If an email has partially the same email as another co-author they will get included. This addresses this issue. [Issue 213](https://github.com/rkotze/git-mob/issues/213)
+
 ## git-mob 4.0.0
 
 ### Added

packages/git-mob-core/src/index.spec.ts

@@ -32,6 +32,7 @@ const mockedGetSetCoAuthors = jest.mocked(getSetCoAuthors);
 describe('Git Mob core API', () => {
   afterEach(() => {
     mockedRemoveGitMobSection.mockReset();
+    mockedGetSetCoAuthors.mockReset();
     mockedGitConfig.getGlobalCommitTemplate.mockReset();
     mockedGitConfig.getLocalCommitTemplate.mockReset();
   });
@@ -137,6 +138,17 @@ describe('Git Mob core API', () => {
     const selectedAuthor = listAll[1];
     mockedGetSetCoAuthors.mockResolvedValueOnce(selectedAuthor.toString());
     const selected = await getSelectedCoAuthors(listAll);
+
+    expect(mockedGetSetCoAuthors).toHaveBeenCalledTimes(1);
+    expect(selected).toEqual([selectedAuthor]);
+  });
+
+  it('Use exact email for selected co-authors', async () => {
+    const listAll = buildAuthorList(['ab', 'efcd', 'cd']);
+    const selectedAuthor = listAll[1];
+    mockedGetSetCoAuthors.mockResolvedValueOnce(selectedAuthor.toString());
+    const selected = await getSelectedCoAuthors(listAll);
+
     expect(mockedGetSetCoAuthors).toHaveBeenCalledTimes(1);
     expect(selected).toEqual([selectedAuthor]);
   });

packages/git-mob-core/src/index.ts

@@ -84,7 +84,7 @@ async function getSelectedCoAuthors(allAuthors: Author[]) {
   const coAuthorConfigValue = await getSetCoAuthors();
   if (coAuthorConfigValue) coAuthorsString = coAuthorConfigValue;
 
-  return allAuthors.filter(author => coAuthorsString.includes(author.email));
+  return allAuthors.filter(author => coAuthorsString.includes('<' + author.email));
 }
 
 async function solo() {