Skip to content

Commit 9920e43

Browse files
author
Richard Piazza
committed
Swift Corrections
Updated accessibility on WebAPI static structs; Corrected NSNull checking on NSBundle.
1 parent 1d1e9ea commit 9920e43

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

CodeQuickKit-Swift/NSBundle.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,22 +121,22 @@ public extension NSBundle {
121121

122122
public func moduleClass(forClassNamed classNamed: String) -> AnyClass {
123123
var moduleClass: AnyClass? = NSClassFromString(classNamed)
124-
if moduleClass != nil {
124+
if moduleClass != nil && moduleClass != NSNull.self {
125125
return moduleClass!
126126
}
127127

128128
if let prefix = bundleDisplayName {
129129
let underscored = prefix.stringByReplacingOccurrencesOfString(" " , withString: "_")
130130
moduleClass = NSClassFromString("\(underscored).\(classNamed)")
131-
if moduleClass != nil {
131+
if moduleClass != nil && moduleClass != NSNull.self {
132132
return moduleClass!
133133
}
134134
}
135135

136136
if let prefix = bundleName {
137137
let underscored = prefix.stringByReplacingOccurrencesOfString(" " , withString: "_")
138138
moduleClass = NSClassFromString("\(underscored).\(classNamed)")
139-
if moduleClass != nil {
139+
if moduleClass != nil && moduleClass != NSNull.self {
140140
return moduleClass!
141141
}
142142
}
@@ -146,7 +146,7 @@ public extension NSBundle {
146146

147147
public func singularizedModuleClass(forClassNamed classNamed: String) -> AnyClass {
148148
var moduleClass: AnyClass? = self.moduleClass(forClassNamed: classNamed)
149-
if moduleClass != nil {
149+
if moduleClass != nil && moduleClass != NSNull.self {
150150
return moduleClass!
151151
}
152152

@@ -160,7 +160,7 @@ public extension NSBundle {
160160
}
161161

162162
moduleClass = self.moduleClass(forClassNamed: singular)
163-
if moduleClass != nil {
163+
if moduleClass != nil && moduleClass != NSNull.self {
164164
return moduleClass!
165165
}
166166

CodeQuickKit-Swift/WebAPI.swift

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,17 @@ public enum WebAPIRequestMethod: String {
3737
}
3838

3939
public struct WebAPIHeaderKey {
40-
static let Accept = "Accept"
41-
static let Date = "Date"
42-
static let ContentType = "Content-Type"
43-
static let ContentMD5 = "Content-MD5"
44-
static let ContentLength = "Content-Length"
45-
static let Authorization = "Authorization"
40+
public static let Accept = "Accept"
41+
public static let Date = "Date"
42+
public static let ContentType = "Content-Type"
43+
public static let ContentMD5 = "Content-MD5"
44+
public static let ContentLength = "Content-Length"
45+
public static let Authorization = "Authorization"
4646
}
4747

4848
public struct WebAPIHeaderValue {
49-
static let ApplicationJson = "application/json"
50-
static let ImagePNG = "image/png"
49+
public static let ApplicationJson = "application/json"
50+
public static let ImagePNG = "image/png"
5151
}
5252

5353
public struct WebAPIInjectedResponse {
@@ -104,7 +104,7 @@ public class WebAPI {
104104
public var baseURL: NSURL?
105105
public var injectedResponses: [String : WebAPIInjectedResponse] = [String : WebAPIInjectedResponse]()
106106
public var sessionDelegate: NSURLSessionDelegate?
107-
private lazy var session: NSURLSession = {
107+
public lazy var session: NSURLSession = {
108108
[unowned self] in
109109
let configuration = NSURLSessionConfiguration.defaultSessionConfiguration()
110110
return NSURLSession(configuration: configuration, delegate: self.sessionDelegate, delegateQueue: nil)
@@ -117,19 +117,19 @@ public class WebAPI {
117117

118118
// MARK: - Convenience Methods
119119

120-
public final func get(path: String, queryItems: [NSURLQueryItem]?, completion: WebAPICompletion) {
120+
public final func get(path: String, queryItems: [NSURLQueryItem]? = nil, completion: WebAPICompletion) {
121121
execute(path, queryItems: queryItems, method: .Get, data: nil, completion: completion)
122122
}
123123

124-
public final func put(data: NSData?, path: String, queryItems: [NSURLQueryItem]?, completion: WebAPICompletion) {
124+
public final func put(data: NSData?, path: String, queryItems: [NSURLQueryItem]? = nil, completion: WebAPICompletion) {
125125
execute(path, queryItems: queryItems, method: .Put, data: data, completion: completion)
126126
}
127127

128-
public final func post(data: NSData?, path: String, queryItems: [NSURLQueryItem]?, completion: WebAPICompletion) {
128+
public final func post(data: NSData?, path: String, queryItems: [NSURLQueryItem]? = nil, completion: WebAPICompletion) {
129129
execute(path, queryItems: queryItems, method: .Post, data: data, completion: completion)
130130
}
131131

132-
public final func delete(path: String, queryItems: [NSURLQueryItem]?, completion: WebAPICompletion) {
132+
public final func delete(path: String, queryItems: [NSURLQueryItem]? = nil, completion: WebAPICompletion) {
133133
execute(path, queryItems: queryItems, method: .Delete, data: nil, completion: completion)
134134
}
135135

CodeQuickKit.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
Pod::Spec.new do |s|
1010
s.name = "CodeQuickKit"
11-
s.version = "2.0.1"
11+
s.version = "2.0.2"
1212
s.summary = "An iOS Library simplifying some everyday tasks."
1313
s.description = <<-DESC
1414
CodeQuickKit is a collection of Swift extensions and classes designed to

0 commit comments

Comments
 (0)