Skip to content

Commit dd3fda9

Browse files
authored
Merge pull request #754 from reviewdog/add_fail_level
Add fail_level and deduplicate fail_on_error
2 parents 745cf59 + db279af commit dd3fda9

File tree

5 files changed

+22
-1
lines changed

5 files changed

+22
-1
lines changed

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,16 @@ It's same as `-reporter` flag of reviewdog.
9090
Optional. Filtering mode for the reviewdog command [added,diff_context,file,nofilter].
9191
Default is added.
9292

93+
### `fail_level`
94+
95+
Optional. If set to `none`, always use exit code 0 for reviewdog.
96+
Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
97+
Possible values: [`none`, `any`, `info`, `warning`, `error`]
98+
Default is `none`.
99+
93100
### `fail_on_error`
94101

102+
Deprecated, use `fail_level` instead.
95103
Optional. Exit code for reviewdog when errors are found [`true`, `false`]
96104
Default is `false`.
97105

action.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,19 @@ inputs:
2828
Default is added.
2929
required: false
3030
default: "added"
31+
fail_level:
32+
description: |
33+
If set to `none`, always use exit code 0 for reviewdog.
34+
Otherwise, exit code 1 for reviewdog if it finds at least 1 issue with severity greater than or equal to the given level.
35+
Possible values: [none,any,info,warning,error]
36+
Default is `none`.
37+
default: 'none'
3138
fail_on_error:
3239
description: |
40+
Deprecated, use `fail_level` instead.
3341
Exit code for reviewdog when errors are found [true,false]
3442
Default is `false`.
43+
deprecationMessage: Deprecated, use `fail_level` instead.
3544
required: false
3645
default: "false"
3746
reviewdog_flags:

dist/index.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/main.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ async function run(): Promise<void> {
2525
const level = core.getInput("level") || "error";
2626
const reporter = core.getInput("reporter") || "github-pr-check";
2727
const filterMode = core.getInput("filter_mode") || "added";
28+
const failLevel = core.getInput("fail_level") || "none";
2829
const failOnError = core.getInput("fail_on_error") || "false";
2930
const reviewdogFlags = core.getInput("reviewdog_flags");
3031
const workdir = core.getInput("workdir") || ".";
@@ -85,6 +86,7 @@ async function run(): Promise<void> {
8586
`-name=${toolName}`,
8687
`-reporter=${reporter}`,
8788
`-filter-mode=${filterMode}`,
89+
`-fail-level=${failLevel}`,
8890
`-fail-on-error=${failOnError}`,
8991
`-level=${level}`,
9092
...flags.parse(reviewdogFlags),

0 commit comments

Comments
 (0)