Fix check for broken fpm-status page #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello @blodan, sorry for the delay. Do you have any idea how can we implement TDD in this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This fix catches all different versions of output that can happen for a non-existing fpm status page.
For example for the php-fpm 7.4 alpine image only "Primary script unknown" is returned. Not sure if this is due to different php versions or if it's always been this way.
I've also noticed that Kubernetes readiness + liveness probes does not catch the output when sent to stderr so you might want to consider removing >&2 from error messages. We are running without them internally and that works great with Kubernetes.
Changes