Merge pull request #185 from enisdenjo/drop-unused-fragment-reference

fix(TypeScriptGenerator): omit FragmentReference from refetchable query

Author: alloy

src/TypeScriptGenerator.ts

@@ -3,7 +3,6 @@ import {
   Fragment,
   IRVisitor,
   LinkedField,
-  Metadata,
   Root,
   ScalarField,
   Schema,
@@ -469,13 +468,6 @@ function createVisitor(
             createRawResponseTypeVisitor(schema, state)
           );
         }
-        const refetchableFragmentName = getRefetchableQueryParentFragmentName(
-          state,
-          node.metadata
-        );
-        if (refetchableFragmentName !== null) {
-          state.runtimeImports.add("FragmentReference");
-        }
         const nodes = [];
         if (state.runtimeImports.size) {
           nodes.push(
@@ -1079,25 +1071,6 @@ function getEnumDefinitions(
   });
 }
 
-// If it's a @refetchable fragment, we generate the $fragmentRef in generated
-// query, and import it in the fragment to avoid circular dependencies
-function getRefetchableQueryParentFragmentName(
-  state: State,
-  metadata: Metadata
-): string | null {
-  if (
-    (metadata && !metadata.isRefetchableQuery) ||
-    (!state.useHaste && !state.useSingleArtifactDirectory)
-  ) {
-    return null;
-  }
-  const derivedFrom = metadata && metadata.derivedFrom;
-  if (derivedFrom !== null && typeof derivedFrom === "string") {
-    return derivedFrom;
-  }
-  return null;
-}
-
 function stringLiteralTypeAnnotation(name: string): ts.TypeNode {
   return ts.createLiteralTypeNode(ts.createLiteral(name));
 }

test/__snapshots__/TypeScriptGenerator-test.ts.snap

@@ -1620,7 +1620,7 @@ export type RefetchableFragment$key = {
 
 
 // RefetchableFragmentQuery.graphql
-import { FragmentReference, FragmentRefs } from "relay-runtime";
+import { FragmentRefs } from "relay-runtime";
 export type RefetchableFragmentQueryVariables = {
     id: string;
 };