Skip to content

Commit 8169a54

Browse files
fix(test): delay apply for alias validation on create new project (#1855)
Co-authored-by: shadow <waqas_zulfiqar@outlook.com>
1 parent a7e347f commit 8169a54

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

e2e/pages/projectsPage.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ export class ProjectsPage {
3737
return this.page.getByTestId(`project-grid-item-title-${projectName}`);
3838
}
3939
gridProjectStarButton(projectName: string): Locator {
40-
return this.page.getByTestId(`project-grid-item-star-btn-wrapper-${projectName}`).locator('button');
40+
return this.page
41+
.getByTestId(`project-grid-item-star-btn-wrapper-${projectName}`)
42+
.locator("button");
4143
}
4244
gridProjectMenuButton(projectName: string): Locator {
4345
return this.page.getByTestId(`project-grid-item-menu-btn-${projectName}`);
@@ -122,7 +124,10 @@ export class ProjectsPage {
122124
await this.projectNameInput.fill(projectName);
123125
await this.projectAliasInput.fill("");
124126
await this.projectAliasInput.fill(projectAlias);
127+
await this.projectAliasInput.blur();
128+
await this.page.waitForTimeout(10000);
125129
await this.descriptionTextarea.fill(description);
130+
await expect(this.applyButton).toBeEnabled();
126131
await this.applyButton.click();
127132
}
128133
async deleteProject(projectName: string) {
@@ -154,7 +159,7 @@ export class ProjectsPage {
154159
const projectItem = this.gridProjectItem(specialProjectName).first();
155160
await projectItem.hover();
156161
const starButton = this.gridProjectStarButton(specialProjectName).first();
157-
const starIcon = starButton.getByTestId('icon-starFilled');
162+
const starIcon = starButton.getByTestId("icon-starFilled");
158163
await expect(starIcon).toBeVisible();
159164
}
160165

@@ -169,7 +174,7 @@ export class ProjectsPage {
169174
const projectItem = this.gridProjectItem(specialProjectName).first();
170175
await projectItem.hover();
171176
const starButton = this.gridProjectStarButton(specialProjectName).first();
172-
const starIcon = starButton.getByTestId('icon-star');
177+
const starIcon = starButton.getByTestId("icon-star");
173178
await expect(starIcon).toBeVisible();
174179
}
175180
starredProjectNameMenuBar(projectName: string): Locator {

e2e/playwright.config.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ dotenv.config({ path: path.resolve(__dirname, ".env") });
2020
export default defineConfig({
2121
globalSetup: require.resolve("./global-setup"),
2222
expect: {
23-
timeout: 15000
23+
timeout: 25000
2424
},
25-
timeout: 25000,
25+
timeout: 40000,
2626
testDir: "./tests",
2727
/* Run tests in files in parallel */
2828
fullyParallel: false,

e2e/tests/dashboard.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ test.describe("DASHBOARD - Test cases", () => {
3131
let recycleBinPage: RecycleBinPage;
3232
let projectScreenPage: ProjectScreenPage;
3333
test.beforeAll(async ({ browser }) => {
34-
test.setTimeout(20000);
3534
context = await browser.newContext({
3635
recordVideo: {
3736
dir: "videos/",

e2e/tests/projects.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ test.describe("Project Management", () => {
2525
let projectScreen: ProjectScreenPage;
2626

2727
test.beforeAll(async ({ browser }) => {
28-
test.setTimeout(20000);
2928
context = await browser.newContext({
3029
recordVideo: {
3130
dir: "videos/",
@@ -89,6 +88,7 @@ test.describe("Project Management", () => {
8988
});
9089

9190
test("Should add new layer and add points on the map", async () => {
91+
test.setTimeout(60000);
9292
await projectScreen.createNewLayer(layerName);
9393
await projectScreen.verifyLayerAdded(layerName);
9494
await projectScreen.clickLayer(layerName);

web/src/app/features/Dashboard/ContentsContainer/Projects/ProjectCreatorModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ const ProjectCreatorModal: FC<ProjectCreatorModalProps> = ({
5757
const { validateProjectAlias } = useValidateProjectAlias();
5858
const [currentWorkspace] = useWorkspace();
5959

60-
const data = useWorkspacePolicyCheck(currentWorkspace?.id as string);
60+
const data = useWorkspacePolicyCheck(currentWorkspace?.id ?? "");
6161
const enableToCreatePrivateProject =
6262
data?.workspacePolicyCheck?.enableToCreatePrivateProject ?? false;
6363

0 commit comments

Comments
 (0)