Skip to content

Commit 7e78c55

Browse files
committed
Updates for review comments
Signed-off-by: Yi Cai <yicai@redhat.com>
1 parent 4668e16 commit 7e78c55

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

docs/Integrate GitOps with Secrets Management.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ There are 3 providers supported by the SSCSID Operator, refer the below links fo
2525
* [You have extracted and prepared the `ccoctl` binary](#obtain-the-ccoctl-tool).
2626
* You have installed the `jq` CLI tool.
2727
* You have access to the cluster as a user with the `cluster-admin` role.
28-
* You have install GitOps Operator and have a GitOps repository ready to use the secrets.
28+
* You have installed GitOps Operator and have a GitOps repository ready to use the secrets.
2929

3030
### Install the SSCSID
3131
To install the Secrets Store CSI driver:
@@ -227,10 +227,10 @@ oc adm policy add-scc-to-user privileged -z csi-secrets-store-provider-aws -n op
227227
- "secretsmanager:DescribeSecret"
228228
effect: Allow
229229
resource: "<aws_secret_arn>"
230-
secretRef:
231-
name: aws-creds
232-
namespace: dev
233-
serviceAccountNames:
230+
secretRef:
231+
name: aws-creds
232+
namespace: dev
233+
serviceAccountNames:
234234
- default
235235
```
236236
@@ -293,18 +293,18 @@ oc adm policy add-scc-to-user privileged -z csi-secrets-store-provider-aws -n op
293293
294294
`SecretProviderClass` resource is namespaced. Create a `secret-provider-class-aws.yaml` file in the same directory where the target deployment is located in your GitOps repository.
295295
296-
*Example `secret-provider-app.yaml` file*
296+
*Example `secret-provider-class-aws.yaml` file*
297297
```
298298
apiVersion: secrets-store.csi.x-k8s.io/v1
299299
kind: SecretProviderClass
300300
metadata:
301301
name: my-aws-provider
302-
namespace: dev \\ Has to match the namespace of the resource which is going to use the secret
302+
namespace: dev # Has to match the namespace of the resource which is going to use the secret
303303
spec:
304-
provider: aws \\ Specify the provider as aws
305-
parameters: \\ Specify provider-specific parameters
304+
provider: aws # Specify the provider as aws
305+
parameters: # Specify provider-specific parameters
306306
objects: |
307-
- objectName: "<your-secret-name>" \\ This is the secret name you created in AWS
307+
- objectName: "<your-secret-name>"
308308
objectType: "secretsmanager"
309309
```
310310
After pushing this YAML file to your GitOps repository, the namespace-scoped `SecretProviderClass` resource will be populated in the target application page in Argo CD UI. You may need to manually **Sync** the `SecretProviderClass` resource if the Sync Policy your application is not set to Auto.

0 commit comments

Comments
 (0)