don't ignore reconciliation error from svc monitor

jaideepr97 · jaideepr97 · commit 75ee30fd0b28 · 2023-11-22T00:00:37.000+05:30
Signed-off-by: Jaideep Rao &lt;jaideep.r97@gmail.com&gt;
diff --git a/controllers/argocd_metrics_controller.go b/controllers/argocd_metrics_controller.go
@@ -175,7 +175,7 @@ func (r *ArgoCDMetricsReconciler) Reconcile(ctx context.Context, request reconci
 
 	err = r.reconcileOperatorMetricsServiceMonitor(reqLogger)
 	if err != nil {
-		return reconcile.Result{}, nil
+		return reconcile.Result{}, err
 	}
 
 	return reconcile.Result{}, nil

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ func (r *ArgoCDMetricsReconciler) Reconcile(ctx context.Context, request reconci`
`175`	`175`
`176`	`176`	`err = r.reconcileOperatorMetricsServiceMonitor(reqLogger)`
`177`	`177`	`if err != nil {`
`178`		`- return reconcile.Result{}, nil`
	`178`	`+ return reconcile.Result{}, err`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`return reconcile.Result{}, nil`