Skip to content

Commit 14801df

Browse files
fix: address review comments
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
1 parent b1e8a93 commit 14801df

File tree

5 files changed

+50
-3
lines changed

5 files changed

+50
-3
lines changed
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# permissions for end users to edit argocdexports.
2+
apiVersion: rbac.authorization.k8s.io/v1
3+
kind: ClusterRole
4+
metadata:
5+
name: notificationsconfiguration-editor-role
6+
rules:
7+
- apiGroups:
8+
- argoproj.io
9+
resources:
10+
- notificationsconfigurations
11+
verbs:
12+
- create
13+
- delete
14+
- get
15+
- list
16+
- patch
17+
- update
18+
- watch
19+
- apiGroups:
20+
- argoproj.io
21+
resources:
22+
- notificationsconfigurations/status
23+
verbs:
24+
- get
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# permissions for end users to view argocdexports.
2+
apiVersion: rbac.authorization.k8s.io/v1
3+
kind: ClusterRole
4+
metadata:
5+
name: notificationsconfiguration-viewer-role
6+
rules:
7+
- apiGroups:
8+
- argoproj.io
9+
resources:
10+
- notificationsconfigurations
11+
verbs:
12+
- get
13+
- list
14+
- watch

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ go 1.20
44

55
require (
66
github.com/argoproj-labs/argo-rollouts-manager v0.0.2-0.20230515023837-0632f3e856d5
7-
github.com/argoproj-labs/argocd-operator v0.9.0-rc3
7+
github.com/argoproj-labs/argocd-operator v0.10.0
88
github.com/coreos/prometheus-operator v0.40.0
99
github.com/go-logr/logr v1.4.1
1010
github.com/google/go-cmp v0.6.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -639,8 +639,8 @@ github.com/apache/thrift v0.13.0/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb
639639
github.com/apache/thrift v0.16.0/go.mod h1:PHK3hniurgQaNMZYaCLEqXKsYK8upmhPbmdP2FXSqgU=
640640
github.com/argoproj-labs/argo-rollouts-manager v0.0.2-0.20230515023837-0632f3e856d5 h1:SlFbeNb42H7DUGzE9B/uYYjlQjNSR4y+eaWiTqN3PGs=
641641
github.com/argoproj-labs/argo-rollouts-manager v0.0.2-0.20230515023837-0632f3e856d5/go.mod h1:AiEjAr6e/DCDiicjoC7W7LaZdO28sfgoBhjbGryzEZ8=
642-
github.com/argoproj-labs/argocd-operator v0.9.0-rc3 h1:5xisEvsjyIQ/JfXM9UxC4+onbwBTBXDntKzp2h9g/WA=
643-
github.com/argoproj-labs/argocd-operator v0.9.0-rc3/go.mod h1:iur73p+s+a7Zh+hHGB0JTYvWxMA/ug3hQ9Z4SqhwqMI=
642+
github.com/argoproj-labs/argocd-operator v0.10.0 h1:B2k6Rwiff3O7fG3K7nNiFuo9TV7Kr0s/K9f4Mo+5Qak=
643+
github.com/argoproj-labs/argocd-operator v0.10.0/go.mod h1:4TThdvK88j46P6ybACEhHHqJstdnF+CFHkmlS068dqk=
644644
github.com/argoproj/argo-cd/v2 v2.10.1 h1:VD06GPeoq14Bo7IfiW+EKim3T1C9xaMElVrEtw+zll0=
645645
github.com/argoproj/argo-cd/v2 v2.10.1/go.mod h1:SK1uGZ9xWVzxuyg079MaO6+hz/Oz9wSDkGyT0gEkYSs=
646646
github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o=

main.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import (
3535
argov1beta1api "github.com/argoproj-labs/argocd-operator/api/v1beta1"
3636
argocdcommon "github.com/argoproj-labs/argocd-operator/common"
3737
argocdprovisioner "github.com/argoproj-labs/argocd-operator/controllers/argocd"
38+
notificationsprovisioner "github.com/argoproj-labs/argocd-operator/controllers/notificationsconfiguration"
3839
monitoringv1 "github.com/coreos/prometheus-operator/pkg/apis/monitoring/v1"
3940
appsv1 "github.com/openshift/api/apps/v1"
4041
configv1 "github.com/openshift/api/config/v1"
@@ -225,6 +226,14 @@ func main() {
225226
os.Exit(1)
226227
}
227228

229+
if err = (&notificationsprovisioner.NotificationsConfigurationReconciler{
230+
Client: mgr.GetClient(),
231+
Scheme: mgr.GetScheme(),
232+
}).SetupWithManager(mgr); err != nil {
233+
setupLog.Error(err, "unable to create controller", "controller", "Notifications Configuration")
234+
os.Exit(1)
235+
}
236+
228237
//+kubebuilder:scaffold:builder
229238

230239
if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {

0 commit comments

Comments
 (0)