Merge pull request #26 from kusha/macos-fix

MacOS compatibility fix

Author: kusha

README.md

@@ -30,3 +30,20 @@ logger.setLevel(logging.DEBUG)
 
 logger.info('Happy Logging!')
 ```
+
+Troubleshooting
+----------
+
+If you see the following error when running on macOS:
+
+```
+Traceback (most recent call last):
+  File "/path/to/kafka-logging-handler/kafka_logger/handlers.py", line 109, in __init__
+    'host_ip': socket.gethostbyname(socket.gethostname())
+socket.gaierror: [Errno 8] nodename nor servname provided, or not known
+```
+
+The issues is that `socket.gethostname()` resolves to a name that is not available in `/etc/hosts`.
+First run `python3 -c "import socket; print(socket.gethostname())"` to get the name (e.g. `MacBook-Pro`).
+Then fix it with `sudo echo 127.0.0.1 MacBook-Pro >> /etc/hosts`, where `MacBook-Pro` is your computer name.
+There won't be OS-specific fix for it in the library.

kafka_logger/handlers.py

@@ -299,7 +299,7 @@ def at_exit(self):
                         "main process termination. This may cause logs loss.",
                         len(children),
                     )
-        while self.mp_log_queue.qsize() != 0:
+        while not self.mp_log_queue.empty():
             time.sleep(KafkaLoggingHandler.__MULTIPROCESSING_QUEUE_FLUSH_DELAY)
         # wait until everything in multiprocessing queue will be buffered
         self.mp_log_handler_flush_lock.acquire()