Skipping index insert in case the annotation has no DomRects

Author: rsimon

packages/text-annotator/src/state/spatialTree.ts

@@ -68,6 +68,8 @@ export const createSpatialTree = <T extends TextAnnotation>(store: Store<T>, con
 
   const insert = (target: TextAnnotationTarget) => {
     const rects = toItems(target, container.getBoundingClientRect());
+    if (rects.length === 0) return;
+
     rects.forEach(rect => tree.insert(rect));
     index.set(target.annotation, rects);
   }
@@ -92,7 +94,10 @@ export const createSpatialTree = <T extends TextAnnotation>(store: Store<T>, con
     const offset = container.getBoundingClientRect();
 
     const rectsByTarget = targets.map(target => ({ target, rects: toItems(target, offset) }));
-    rectsByTarget.forEach(({ target, rects }) => index.set(target.annotation, rects));
+    rectsByTarget.forEach(({ target, rects }) => {
+      if (rects.length > 0)
+        index.set(target.annotation, rects)
+    });
 
     const allRects = rectsByTarget.flatMap(({ rects }) => rects);
     tree.load(allRects);
@@ -144,7 +149,7 @@ export const createSpatialTree = <T extends TextAnnotation>(store: Store<T>, con
 
   const getAnnotationRects = (id: string): DOMRect[] => {
     const indexed = index.get(id);
-    if (indexed[0]) {
+    if (indexed) {
       // Reminder: *each* IndexedHighlightRect stores *all*
       // DOMRects for the annotation for convenience
       return indexed[0].annotation.rects;