Fixed checking null selection for not annotatable

oleksandr-danylchenko · oleksandr-danylchenko · commit 87587d278af1 · 2024-10-15T19:57:49.000+03:00
diff --git a/packages/text-annotator/src/SelectionHandler.ts b/packages/text-annotator/src/SelectionHandler.ts
@@ -80,7 +80,7 @@ export const SelectionHandler = (
     // This is to handle cases where the selection is "hijacked" by another element
     // in a not-annotatable area. A rare case in theory. But rich text editors
     // will like Quill do it...
-    if (isNotAnnotatable(sel.anchorNode)) {
+    if (!sel?.isCollapsed && isNotAnnotatable(sel.anchorNode)) {
       currentTarget = undefined;
       return;
     }

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ export const SelectionHandler = (`
`80`	`80`	`// This is to handle cases where the selection is "hijacked" by another element`
`81`	`81`	`// in a not-annotatable area. A rare case in theory. But rich text editors`
`82`	`82`	`// will like Quill do it...`
`83`		`- if (isNotAnnotatable(sel.anchorNode)) {`
	`83`	`+ if (!sel?.isCollapsed && isNotAnnotatable(sel.anchorNode)) {`
`84`	`84`	`currentTarget = undefined;`
`85`	`85`	`return;`
`86`	`86`	`}`