[RKOTLIN-1100] Clean up build system (#1770)

Author: clementetb

.gitignore

@@ -329,3 +329,11 @@ DerivedData/
 
 # End of https://www.gitignore.io/api/c,git,c++,java,cmake,xcode,kotlin,android,intellij,visualstudiocode
 dynamic_libraries.properties
+
+**/.kotlin
+
+**/output
+
+packages/test-sync/mongodb-realm/
+
+packages/m2-buildrepo

CHANGELOG.md

@@ -98,11 +98,12 @@
 * Minimum Gradle version: 7.2.
 * Minimum Android Gradle Plugin version: 7.1.3.
 * Minimum Android SDK: 16.
-* Minimum R8: 8.0.34.
+* Minimum R8: 8.3.37.
 
 ### Internal
 * Updated to Realm Core 14.7.0 commit c280bdb17522323d5c30dc32a2b9efc9dc80ca3b.
 * Changed Kotlin compiler testing framework to https://github.com/zacsweers/kotlin-compile-testing
+* Updated to Detekt 1.23.6.
 
 
 ## 1.16.0 (2024-05-01)

benchmarks/androidApp/build.gradle.kts

@@ -5,6 +5,8 @@ plugins {
 }
 
 android {
+    namespace = "io.realm.kotlin.benchmarks.android"
+    testNamespace = "io.realm.kotlin.benchmarks.android.test"
     compileSdk = Versions.Android.compileSdkVersion
 
     compileOptions {

benchmarks/androidApp/src/androidTest/AndroidManifest.xml

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools"
-    package="io.realm.kotlin.benchmarks.android.test">
+    xmlns:tools="http://schemas.android.com/tools">
 
     <!--
       Important: disable debugging for accurate performance results
@@ -13,5 +12,5 @@
         android:debuggable="false"
         android:requestLegacyExternalStorage="true"
         tools:ignore="HardcodedDebugMode"
-        tools:replace="android:debuggable" />
+        />
 </manifest>

benchmarks/androidApp/src/main/AndroidManifest.xml

@@ -1,2 +1,2 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest package="io.realm.kotlin.benchmarks.android" />
+<manifest/>

benchmarks/gradle.properties

@@ -6,3 +6,5 @@ kotlin.code.style=official
 
 #Android
 android.useAndroidX=true
+
+kotlin.mpp.applyDefaultHierarchyTemplate=false

benchmarks/shared/build.gradle.kts

@@ -8,7 +8,7 @@ plugins {
 version = "1.0"
 
 kotlin {
-    android()
+    androidTarget()
     jvm()
 // Disable iOS until needed
 //    iosX64()
@@ -31,9 +31,6 @@ kotlin {
                 implementation("io.realm.kotlin:library-sync:${Realm.version}")
             }
         }
-        val main by creating {
-            dependsOn(commonMain)
-        }
         val androidMain by getting
 // Disable iOS until needed
 //        val iosX64Main by getting
@@ -58,6 +55,7 @@ kotlin {
 }
 
 android {
+    namespace = "io.realm.kotlin.benchmarks"
     compileSdk = Versions.Android.compileSdkVersion
     sourceSets["main"].manifest.srcFile("src/androidMain/AndroidManifest.xml")
     defaultConfig {

benchmarks/shared/src/androidMain/AndroidManifest.xml

@@ -1,2 +1,2 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest package="io.realm.kotlin.benchmarks" />
+<manifest/>

buildSrc/build.gradle.kts

@@ -55,7 +55,6 @@ dependencies {
     implementation("io.gitlab.arturbosch.detekt:detekt-gradle-plugin:${Versions.detektPlugin}")
     implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:${Versions.kotlin}")
     implementation("com.android.tools:r8:${Versions.Android.r8}")
-    implementation("com.android.tools.build:gradle:${Versions.Android.buildTools}") // TODO LATER Don't know why this has to be here. See if we can remove this
-    implementation("com.android.tools.build:gradle-api:${Versions.Android.buildTools}")
+    implementation("com.android.tools.build:gradle:${Versions.Android.buildTools}")
     implementation(kotlin("script-runtime"))
 }

buildSrc/gradle.properties

@@ -0,0 +1,16 @@
+#
+# Copyright 2024 Realm Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+kotlin.options.suppressFreeCompilerArgsModificationWarning=true