Merge pull request #12 from reactphp-parallel/quote-fix-quote-infection-issues

"fix" infection issues

Author: WyriHaximus

infection.json.dist

@@ -10,10 +10,43 @@
     },
     "mutators": {
         "@default": true,
+        "FunctionCallRemoval": {
+            "ignore": [
+                "ReactParallel\\Pool\\Worker\\Worker::perform::76"
+            ]
+        },
+        "GreaterThan": {
+            "ignore": [
+                "ReactParallel\\Pool\\Worker\\Thread::close::85"
+            ]
+        },
+        "GreaterThanNegotiation": {
+            "ignore": [
+                "ReactParallel\\Pool\\Worker\\Thread::close::85"
+            ]
+        },
+        "Identical": {
+            "ignore": [
+                "ReactParallel\\Pool\\Worker\\Thread::__construct::43",
+                "ReactParallel\\Pool\\Worker\\Thread::close::85",
+                "ReactParallel\\Pool\\Worker\\Worker::getIdleThread::137"
+            ]
+        },
         "MethodCallRemoval": {
             "ignore": [
-                "ReactParallel\\Pool\\Infinite\\Infinite::startTtlTimer::189"
+                "ReactParallel\\Pool\\Worker\\Infinite::startTtlTimer::189",
+                "ReactParallel\\Pool\\Worker\\Thread::__construct::44",
+                "ReactParallel\\Pool\\Worker\\Thread::close::89",
+                "ReactParallel\\Pool\\Worker\\Worker::perform::87",
+                "ReactParallel\\Pool\\Worker\\Worker::kill::111",
+                "ReactParallel\\Pool\\Worker\\Worker::getIdleThread::138",
+                "ReactParallel\\Pool\\Worker\\Worker::startTtlTimer::164"
+            ]
+        },
+        "NotIdentical": {
+            "ignore": [
+                "ReactParallel\\Pool\\Worker\\Thread::close::85"
             ]
         }
     }
-}
+}

tests/WorkerTest.php

@@ -143,8 +143,16 @@ public function close(): void
         $poolProperty->setAccessible(true);
         $poolProperty->setValue($parallelFactory, $pool->reveal());
 
-        $pool = new Worker($parallelFactory, $workerFactory, 1);
-        $pool->close();
+        $workerPool = new Worker($parallelFactory, $workerFactory, 1);
+        $workerPool->close();
+
+        self::assertSame([
+            Info::TOTAL => 0,
+            Info::BUSY => 0,
+            Info::CALLS => 0,
+            Info::IDLE => 0,
+            Info::SIZE => 0,
+        ], iterator_to_array($workerPool->info()));
     }
 
     /**
@@ -166,7 +174,16 @@ public function kill(): void
         $poolProperty->setAccessible(true);
         $poolProperty->setValue($parallelFactory, $pool->reveal());
 
-        $pool = new Worker($parallelFactory, $workerFactory, 1);
-        $pool->kill();
+        $workerPool = new Worker($parallelFactory, $workerFactory, 1);
+//        $workerPool->
+        $workerPool->kill();
+
+        self::assertSame([
+            Info::TOTAL => 0,
+            Info::BUSY => 0,
+            Info::CALLS => 0,
+            Info::IDLE => 0,
+            Info::SIZE => 0,
+        ], iterator_to_array($workerPool->info()));
     }
 }

tests/Workers/ThrowingReturnTest.php

@@ -18,7 +18,8 @@ final class ThrowingReturnTest extends AsyncTestCase
      */
     public function thrown(): void
     {
-        $money = null;
+        $money      = null;
+        $thrownWork = null;
         try {
             (new ThrowingReturnWorkerFactory())->construct()->perform(new Work(Money::EUR(512)));
         } catch (ThrownWork $thrownWork) {
@@ -27,6 +28,8 @@ public function thrown(): void
             throw $throwable;
         }
 
+        self::assertNotNull($thrownWork);
+        self::assertSame('Throwing work', $thrownWork->getMessage());
         self::assertNotNull($money);
         self::assertInstanceOf(Money::class, $money);
         self::assertSame('512', $money->getAmount());