Skip to content

feat: improved accessibility #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2025
Merged

feat: improved accessibility #299

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b22e446
feat: add role attribute to InternalSegmentedOption for improved acce…
aojunhao123 Jan 21, 2025
00c297c
fix: update role and aria attributes
aojunhao123 Jan 21, 2025
3355ab7
test: update snapshot
aojunhao123 Jan 21, 2025
41ef344
chore: add @rc-component/np dependency and remove np package
aojunhao123 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ const InternalSegmentedOption: React.FC<{
segmentedClassNames?.label,
)}
title={title}
aria-selected={checked}
role="radio"
aria-checked={checked}
style={styles?.label}
>
{label}
Expand Down
Loading
Loading