Skip to content

fix: add aria-hidden attribute to visually hidden input element #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2024
Merged

fix: add aria-hidden attribute to visually hidden input element #279

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc04e6d
fix: add aria-hidden attribute to visually hidden input element
Oct 25, 2024
bf9c01c
test: update snapshot
Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ const InternalSegmentedOption: React.FC<{
>
<input
className={`${prefixCls}-item-input`}
aria-hidden="true"
Copy link
Member

@zombieJ zombieJ Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input 不是内部状态管理，而是专门用来做无障碍的。如果影响读屏器，应该是把其他的藏起来，而只保留 input 的读屏能力

type="radio"
disabled={disabled}
checked={checked}
Expand Down
Loading