Merge pull request #432 from corvec/bug/fix-inline-card-editing

Remove references to confusing second updateCard action

Author: dapi

src/controllers/Lane.js

@@ -142,7 +142,7 @@ class Lane extends Component {
   }
 
   updateCard = updatedCard => {
-    this.props.actions.updateCard({laneId: this.props.id, updatedCard})
+    this.props.actions.updateCard({laneId: this.props.id, card: updatedCard})
     this.props.onCardUpdate(this.props.id, updatedCard)
   }
 

src/helpers/LaneHelper.js

@@ -68,28 +68,6 @@ const LaneHelper = {
     return update(state, {lanes: {$set: lanes}})
   },
 
-  updateCardFromLane: (state, {laneId, card}) => {
-    const laneIndex = state.lanes.findIndex(x => x.id === laneId)
-    if (laneIndex < 0) {
-      return state
-    }
-    const cardIndex = state.lanes[laneIndex].cards.findIndex(x => x.id === card.id)
-    if (cardIndex < 0) {
-      return state
-    }
-    return update(state, {
-      lanes: {
-        [laneIndex]: {
-          cards: {
-            [cardIndex]: {
-              $set: card
-            }
-          }
-        }
-      }
-    })
-  },
-
   moveCardAcrossLanes: (state, {fromLaneId, toLaneId, cardId, index}) => {
     let cardToMove = null
     const interimLanes = state.lanes.map(lane => {
@@ -116,7 +94,7 @@ const LaneHelper = {
     return update(state, {lanes: {$set: lanes}})
   },
 
-  updateCardForLane: (state, {laneId, updatedCard}) => {
+  updateCardForLane: (state, {laneId, card: updatedCard}) => {
     const lanes = state.lanes.map(lane => {
       if (lane.id === laneId) {
         const cards = lane.cards.map(card => {

src/reducers/BoardReducer.js

@@ -7,8 +7,6 @@ const boardReducer = (state = {lanes: []}, action) => {
       return Lh.initialiseLanes(state, payload)
     case 'ADD_CARD':
       return Lh.appendCardToLane(state, payload)
-    case 'UPDATE_CARD':
-      return Lh.updateCardFromLane(state, payload)
     case 'REMOVE_CARD':
       return Lh.removeCardFromLane(state, payload)
     case 'MOVE_CARD':