Valhalla 26 build compatibility

[wendigo]

Hi @raphw

I wanted to test out Valhalla build based on JDK 26 and right now it fails on:

java.lang.IllegalStateException: Illegal modifiers 33 for class io.trino.plugin.eventlistener.mysql.MysqlEventListenerConfig$ByteBuddy$VbvA5glI
        at net.bytebuddy.dynamic.scaffold.InstrumentedType$Default.validated(InstrumentedType.java:1556)
        at net.bytebuddy.dynamic.scaffold.MethodRegistry$Default.prepare(MethodRegistry.java:519)
        at net.bytebuddy.dynamic.scaffold.subclass.SubclassDynamicTypeBuilder.toTypeWriter(SubclassDynamicTypeBuilder.java:222)
        at net.bytebuddy.dynamic.scaffold.subclass.SubclassDynamicTypeBuilder.toTypeWriter(SubclassDynamicTypeBuilder.java:213)
        at net.bytebuddy.dynamic.DynamicType$Builder$AbstractBase$UsingTypeWriter.make(DynamicType.java:4085)
        at net.bytebuddy.dynamic.DynamicType$Builder$AbstractBase.make(DynamicType.java:3769)
        at net.bytebuddy.dynamic.DynamicType$Builder$AbstractBase$Delegator.make(DynamicType.java:4021)
        at io.airlift.configuration.testing.ConfigAssertions.recordDefaults(ConfigAssertions.java:298)
        at io.trino.plugin.eventlistener.mysql.TestMysqlEventListenerConfig.testDefaults(TestMysqlEventListenerConfig.java:30)

Can we add support for Valhalla modifiers so it's possible to use bytebuddy with early access Valhalla build?

[wendigo]

@raphw any pointers here?

[raphw]

Sorry, I missed that one. I will add the modifiers. In the meantime, you could disable validation on ByteBuddy.

[wendigo]

@raphw no worries :)

[raphw]

Could you build master and see if this works? I added ACC_IDENTITY to the list of allowed modifiers.

[wendigo]

@raphw building now :)

[wendigo]

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.242 s
[INFO] Finished at: 2025-11-26T21:26:48+01:00
[INFO] ------------------------------------------------------------------------

Works with the snapshot :)