fix: trying to solve a bug where the parent router doesn't pass its middlewares to its groups routers (part II)

Author: ralvarezdev

http/module.go

@@ -45,22 +45,6 @@ func (m *Module) Create(
 		m.BeforeLoadFn(m)
 	}
 
-	// Append the router middlewares to the module middlewares
-	if baseRouter.GetMiddlewares() != nil {
-		if m.Middlewares == nil {
-			m.Middlewares = NewMiddlewares(*baseRouter.GetMiddlewares()...)
-		} else {
-			// Get the base router middlewares
-			moduleMiddlewares := NewMiddlewares(*baseRouter.GetMiddlewares()...)
-
-			// Append the module middlewares to the base router middlewares
-			*moduleMiddlewares = append(*moduleMiddlewares, *m.Middlewares...)
-
-			// Set the module middlewares
-			m.Middlewares = moduleMiddlewares
-		}
-	}
-
 	// Set the base route
 	if m.Middlewares != nil {
 		m.RouterWrapper = baseRouter.NewGroup(m.Pattern, *m.Middlewares...)

http/route/router.go

@@ -167,19 +167,28 @@ func NewGroup(
 	// Initialize the multiplexer
 	mux := http.NewServeMux()
 
+	// Create the middlewares slice
+	var allMiddlewares []func(http.Handler) http.Handler
+
+	// Append the base router middlewares
+	allMiddlewares = append(allMiddlewares, *baseRouter.GetMiddlewares()...)
+
+	// Append the new middlewares
+	allMiddlewares = append(allMiddlewares, middlewares...)
+
 	// Check if there is a nil middleware
-	for i, middleware := range middlewares {
+	for i, middleware := range allMiddlewares {
 		if middleware == nil {
 			return nil, fmt.Errorf(ErrNilMiddleware, fullPath, i)
 		}
 	}
 
 	// Chain the handlers
-	firstHandler := ChainHandlers(mux, middlewares...)
+	firstHandler := ChainHandlers(mux, allMiddlewares...)
 
 	// Create a new router
 	instance := &Router{
-		middlewares:  middlewares,
+		middlewares:  allMiddlewares,
 		firstHandler: firstHandler,
 		mux:          mux,
 		logger:       baseRouter.logger,
@@ -301,17 +310,8 @@ func (r *Router) NewGroup(
 	pattern string,
 	middlewares ...func(next http.Handler) http.Handler,
 ) *Router {
-	// Create the middlewares slice
-	var fullMiddlewares []func(http.Handler) http.Handler
-
-	// Append the base router middlewares
-	fullMiddlewares = append(fullMiddlewares, r.middlewares...)
-
-	// Append the new middlewares
-	fullMiddlewares = append(fullMiddlewares, middlewares...)
-
 	// Create a new group
-	newGroup, _ := NewGroup(r, pattern, fullMiddlewares...)
+	newGroup, _ := NewGroup(r, pattern, middlewares...)
 	return newGroup
 }