bpp-lsp: bug fix: avoid re-parsing twice

rail5 · rail5 · commit ff4302835796 · 2025-08-19T17:34:01.000+08:00
diff --git a/src/lsp/ProgramPool.cpp b/src/lsp/ProgramPool.cpp
@@ -208,7 +208,7 @@ std::shared_ptr<bpp::bpp_program> ProgramPool::re_parse_program(const std::strin
 			return nullptr; // Return nullptr if parsing fails
 		}
 
-		programs[index] = _parse_program(main_source_file);
+		programs[index] = new_program;
 		open_files[file_path] = true; // Mark the file as open
 
 		update_snapshot();
@@ -234,7 +234,7 @@ std::shared_ptr<bpp::bpp_program> ProgramPool::re_parse_program(
 			return nullptr; // Return nullptr if parsing fails
 		}
 
-		programs[index] = _parse_program(main_source_file, replacement_file_contents);
+		programs[index] = new_program;
 		open_files[file_path] = true; // Mark the file as open
 
 		update_snapshot();

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ std::shared_ptr<bpp::bpp_program> ProgramPool::re_parse_program(const std::strin`
`208`	`208`	`return nullptr; // Return nullptr if parsing fails`
`209`	`209`	`}`
`210`	`210`
`211`		`- programs[index] = _parse_program(main_source_file);`
	`211`	`+ programs[index] = new_program;`
`212`	`212`	`open_files[file_path] = true; // Mark the file as open`
`213`	`213`
`214`	`214`	`update_snapshot();`
`@@ -234,7 +234,7 @@ std::shared_ptr<bpp::bpp_program> ProgramPool::re_parse_program(`
`234`	`234`	`return nullptr; // Return nullptr if parsing fails`
`235`	`235`	`}`
`236`	`236`
`237`		`- programs[index] = _parse_program(main_source_file, replacement_file_contents);`
	`237`	`+ programs[index] = new_program;`
`238`	`238`	`open_files[file_path] = true; // Mark the file as open`
`239`	`239`
`240`	`240`	`update_snapshot();`