Skip to content

Commit d7761d6

Browse files
committed
*.: fix default mysql version 5.7.33 to 5.7.34 #200
[summary] change default mysql version to 5.7.34 and add it to tag list
1 parent 0c498e5 commit d7761d6

File tree

5 files changed

+16
-15
lines changed

5 files changed

+16
-15
lines changed

cluster/cluster_test.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ func TestGetLabel(t *testing.T) {
7474
"mysql.radondb.com/cluster": "sample",
7575
"app.kubernetes.io/name": "mysql",
7676
"app.kubernetes.io/instance": "instance",
77-
"app.kubernetes.io/version": "5.7.33",
77+
"app.kubernetes.io/version": "5.7.34",
7878
"app.kubernetes.io/component": "database",
7979
"app.kubernetes.io/managed-by": "mysql.radondb.com",
8080
}
@@ -93,7 +93,7 @@ func TestGetLabel(t *testing.T) {
9393
"mysql.radondb.com/cluster": "sample",
9494
"app.kubernetes.io/name": "mysql",
9595
"app.kubernetes.io/instance": "sample",
96-
"app.kubernetes.io/version": "5.7.33",
96+
"app.kubernetes.io/version": "5.7.34",
9797
"app.kubernetes.io/component": "component",
9898
"app.kubernetes.io/managed-by": "mysql.radondb.com",
9999
}
@@ -112,7 +112,7 @@ func TestGetLabel(t *testing.T) {
112112
"mysql.radondb.com/cluster": "sample",
113113
"app.kubernetes.io/name": "mysql",
114114
"app.kubernetes.io/instance": "sample",
115-
"app.kubernetes.io/version": "5.7.33",
115+
"app.kubernetes.io/version": "5.7.34",
116116
"app.kubernetes.io/component": "database",
117117
"app.kubernetes.io/managed-by": "mysql.radondb.com",
118118
"app.kubernetes.io/part-of": "part-of",
@@ -131,34 +131,34 @@ func TestGetSelectorLabels(t *testing.T) {
131131
}
132132

133133
func TestGetMySQLVersion(t *testing.T) {
134-
// other 8.0 -> 5.7.33
134+
//other 8.0 -> 5.7.34
135135
{
136136
testMysqlCluster := mysqlCluster
137137
testMysqlCluster.Spec.MysqlVersion = "8.0"
138138
testCase := Cluster{
139139
&testMysqlCluster,
140140
}
141-
want := "5.7.33"
141+
want := "5.7.34"
142142
assert.Equal(t, want, testCase.GetMySQLVersion())
143143
}
144-
// MySQLTagsToSemVer 5.7 -> 5.7.33
144+
//MySQLTagsToSemVer 5.7 -> 5.7.34
145145
{
146146
testMysqlCluster := mysqlCluster
147147
testMysqlCluster.Spec.MysqlVersion = "5.7"
148148
testCase := Cluster{
149149
&testMysqlCluster,
150150
}
151-
want := "5.7.33"
151+
want := "5.7.34"
152152
assert.Equal(t, want, testCase.GetMySQLVersion())
153153
}
154-
// MysqlImageVersions 5.7.33 -> 5.7.33
154+
//MysqlImageVersions 5.7.34 -> 5.7.34
155155
{
156156
testMysqlCluster := mysqlCluster
157-
testMysqlCluster.Spec.MysqlVersion = "5.7.33"
157+
testMysqlCluster.Spec.MysqlVersion = "5.7.34"
158158
testCase := Cluster{
159159
&testMysqlCluster,
160160
}
161-
want := "5.7.33"
161+
want := "5.7.34"
162162
assert.Equal(t, want, testCase.GetMySQLVersion())
163163
}
164164
}

cluster/container/init_mysql_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func TestGetInitMysqlName(t *testing.T) {
105105
}
106106

107107
func TestGetInitMysqlImage(t *testing.T) {
108-
assert.Equal(t, "percona/percona-server:5.7.33", initMysqlCase.Image)
108+
assert.Equal(t, "percona/percona-server:5.7.34", initMysqlCase.Image)
109109
}
110110

111111
func TestGetInitMysqlCommand(t *testing.T) {

cluster/container/init_sidecar_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ var (
101101
},
102102
{
103103
Name: "MYSQL_VERSION",
104-
Value: "5.7.33",
104+
Value: "5.7.34",
105105
},
106106
{
107107
Name: "RESTORE_FROM",

cluster/container/mysql_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ func TestGetMysqlName(t *testing.T) {
5252
}
5353

5454
func TestGetMysqlImage(t *testing.T) {
55-
assert.Equal(t, "percona/percona-server:5.7.33", mysqlCase.Image)
55+
assert.Equal(t, "percona/percona-server:5.7.34", mysqlCase.Image)
5656
}
5757

5858
func TestGetMysqlCommand(t *testing.T) {

utils/constants.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,17 @@ package utils
1818

1919
var (
2020
// MySQLDefaultVersion is the version for mysql that should be used
21-
MySQLDefaultVersion = "5.7.33"
21+
MySQLDefaultVersion = "5.7.34"
2222

2323
// MySQLTagsToSemVer maps simple version to semver versions
2424
MySQLTagsToSemVer = map[string]string{
25-
"5.7": "5.7.33",
25+
"5.7": "5.7.34",
2626
}
2727

2828
// MysqlImageVersions is a map of supported mysql version and their image
2929
MysqlImageVersions = map[string]string{
3030
"5.7.33": "percona/percona-server:5.7.33",
31+
"5.7.34": "percona/percona-server:5.7.34",
3132
}
3233
)
3334

0 commit comments

Comments
 (0)