Skip cpu if cannot do better #6001
Merged
+375
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton-dd
force-pushed
the
skip_cpu_if_cannot_do_better
branch
2 times, most recently
from
e173275 to
6aea30d
Compare
Also, - removes some noisy intermediary traces/span. - logs the ast/agg in the root node. - logs a summary about the split execution (cache, pruned, etc.) in the leaf node
fulmicoton-dd
force-pushed
the
skip_cpu_if_cannot_do_better
branch
from
6aea30d to
0ad1b4f
Compare
| targeted_splits_buckets, | ||
| ), | ||
| leaf_searches_splits_total: new_counter( | ||
| "leaf_searches_splits_total", |
Contributor
There was a problem hiding this comment.
todo: check if any dashboard we provide needs updating
fulmicoton-dd
force-pushed
the
skip_cpu_if_cannot_do_better
branch
from
4d6de63 to
fed8a1b
Compare
fulmicoton-dd
force-pushed
the
skip_cpu_if_cannot_do_better
branch
from
e1c831d to
31d5857
Compare
fulmicoton
commented
Nov 28, 2025
trinity-1686a
approved these changes
Nov 28, 2025
fulmicoton-dd
force-pushed
the
skip_cpu_if_cannot_do_better
branch
from
53fd751 to
610bd17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.