Skip to content

Fix #153: Cleanup pgAdmin dev service #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 2 commits into from
Jul 9, 2025
Merged

Fix #153: Cleanup pgAdmin dev service #151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1863c0
Fix #81: Cleanup pgAdmin dev service
melloware Jul 1, 2025
1677e70
Update PgAdminProcessor.java
melloware Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...io/quarkiverse/embedded/postgresql/deployment/devui/EmbeddedPostgreSQLDevUIProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ void createVersion(BuildProducer<CardPageBuildItem> cardPageBuildItemBuildProduc
.dynamicLabelJsonRPCMethodName("getDatasourcePort");
card.addPage(portPage);

final PageBuilder pgAdminPage = Page.externalPageBuilder("Postgre Admin UI")
final PageBuilder pgAdminPage = Page.externalPageBuilder("pgAdmin UI")
Copy link
Contributor Author

@melloware melloware Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed spelling and name.

.icon("font-awesome-solid:database")
.url(managementBase);
.url(managementBase, managementBase)
Copy link
Contributor Author

@melloware melloware Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow the pgAdmin to be opened in new tab

.isHtmlContent();
card.addPage(pgAdminPage);

card.setCustomCard("qwc-embedded-postgresql-card.js");
Expand Down
4 changes: 4 additions & 0 deletions ...t/src/main/java/io/quarkiverse/embedded/postgresql/deployment/devui/PgAdminProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,20 @@
import io.quarkiverse.embedded.postgresql.devui.PgAdminUiProxy;
import io.quarkus.deployment.IsDevelopment;
import io.quarkus.deployment.IsLocalDevelopment;
import io.quarkus.deployment.IsNormal;
import io.quarkus.deployment.annotations.BuildProducer;
import io.quarkus.deployment.annotations.BuildStep;
import io.quarkus.deployment.annotations.BuildSteps;
import io.quarkus.deployment.annotations.ExecutionTime;
import io.quarkus.deployment.annotations.Record;
import io.quarkus.deployment.builditem.DevServicesResultBuildItem;
import io.quarkus.deployment.builditem.LaunchModeBuildItem;
import io.quarkus.deployment.dev.devservices.GlobalDevServicesConfig;
import io.quarkus.vertx.core.deployment.CoreVertxBuildItem;
import io.quarkus.vertx.http.deployment.NonApplicationRootPathBuildItem;
import io.quarkus.vertx.http.deployment.RouteBuildItem;

@BuildSteps(onlyIfNot = IsNormal.class, onlyIf = GlobalDevServicesConfig.Enabled.class)
Copy link
Contributor Author

@melloware melloware Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Respect quarkus.devservices.enabled=false flag if devservices are disabled entirely.

public class PgAdminProcessor {

private final static String CONTAINER_ID = "quarkus-embedded-postgresql-pgadmin";
Expand Down
1 change: 1 addition & 0 deletions runtime/src/main/resources/META-INF/quarkus-extension.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ metadata:
- "data"
config:
- "quarkus.embedded.postgresql."
- "quarkus.pgadmin-ui."
status: "preview"
guide: "https://quarkiverse.github.io/quarkiverse-docs/quarkus-embedded-postgresql/dev/index.html"
icon-url: "https://wiki.postgresql.org/images/a/a4/PostgreSQL_logo.3colors.svg"