Fix #153: Cleanup pgAdmin dev service #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
commented
Jul 1, 2025
| card.addPage(portPage); | ||
|
|
||
| final PageBuilder pgAdminPage = Page.externalPageBuilder("Postgre Admin UI") | ||
| final PageBuilder pgAdminPage = Page.externalPageBuilder("pgAdmin UI") |
Contributor
Author
There was a problem hiding this comment.
Fixed spelling and name.
| final PageBuilder pgAdminPage = Page.externalPageBuilder("pgAdmin UI") | ||
| .icon("font-awesome-solid:database") | ||
| .url(managementBase); | ||
| .url(managementBase, managementBase) |
Contributor
Author
There was a problem hiding this comment.
Allow the pgAdmin to be opened in new tab
| import io.quarkus.vertx.http.deployment.NonApplicationRootPathBuildItem; | ||
| import io.quarkus.vertx.http.deployment.RouteBuildItem; | ||
|
|
||
| @BuildSteps(onlyIfNot = IsNormal.class, onlyIf = GlobalDevServicesConfig.Enabled.class) |
Contributor
Author
There was a problem hiding this comment.
Respect quarkus.devservices.enabled=false flag if devservices are disabled entirely.
melloware
changed the title
ricardozanini
approved these changes
Jul 2, 2025
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
Once we merge, I'll do a patch release.
Contributor
Author
|
Any chance to get this merged and released? |
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #153: Cleanup pgAdmin dev service