Add some missing self-adjoints, use CtrlSpec instead of control_values (#1360)

* self adjoints

* use ctrlspec

Author: anurudhp

qualtran/bloqs/phase_estimation/qubitization_qpe.py

@@ -18,7 +18,15 @@
 import cirq
 import numpy as np
 
-from qualtran import Bloq, bloq_example, BloqDocSpec, GateWithRegisters, Register, Signature
+from qualtran import (
+    Bloq,
+    bloq_example,
+    BloqDocSpec,
+    CtrlSpec,
+    GateWithRegisters,
+    Register,
+    Signature,
+)
 from qualtran.bloqs.phase_estimation.qpe_window_state import QPEWindowStateBase
 from qualtran.bloqs.qft.qft_text_book import QFTTextBook
 from qualtran.bloqs.qubitization.qubitization_walk_operator import QubitizationWalkOperator
@@ -108,8 +116,8 @@ def decompose_from_registers(
         walk_regs = {reg.name: quregs[reg.name] for reg in self.walk.signature}
         reflect_regs = {reg.name: walk_regs[reg.name] for reg in self.walk.reflect.signature}
 
-        reflect_controlled = self.walk.reflect.controlled(control_values=[0])
-        walk_controlled = self.walk.controlled(control_values=[1])
+        reflect_controlled = self.walk.reflect.controlled(ctrl_spec=CtrlSpec(cvs=0))
+        walk_controlled = self.walk.controlled()
 
         qpre_reg = quregs['qpe_reg']
 
@@ -128,8 +136,8 @@ def build_call_graph(self, ssa: 'SympySymbolAllocator') -> Set['BloqCountT']:
         M = 2**self.m_bits
         return {
             (self.ctrl_state_prep, 1),
-            (self.walk.controlled(control_values=[1]), 1),
-            (self.walk.reflect.controlled(control_values=[0]), 2 * (self.m_bits - 1)),
+            (self.walk.controlled(), 1),
+            (self.walk.reflect.controlled(ctrl_spec=CtrlSpec(cvs=0)), 2 * (self.m_bits - 1)),
             (self.walk, M - 2),
             (self.qft_inv, 1),
         }

qualtran/bloqs/reflections/prepare_identity.py

@@ -67,6 +67,9 @@ def build_composite_bloq(self, bb: 'BloqBuilder', **soqs: Soquet) -> Dict[str, S
             soqs[label] = bb.add(Identity(soq.reg.bitsize), q=soq)
         return soqs
 
+    def adjoint(self) -> 'PrepareIdentity':
+        return self
+
 
 @bloq_example(generalizer=ignore_split_join)
 def _prepare_identity() -> PrepareIdentity:

qualtran/bloqs/reflections/reflection_using_prepare.py

@@ -179,6 +179,9 @@ def build_call_graph(self, ssa: 'SympySymbolAllocator') -> Set['BloqCountT']:
             costs.add((phase_op, 1))
         return costs
 
+    def adjoint(self) -> 'ReflectionUsingPrepare':
+        return self
+
 
 @bloq_example(generalizer=ignore_split_join)
 def _refl_using_prep() -> ReflectionUsingPrepare: