Skip to content

Commit 0de3a95

Browse files
author
Nick Shaforostov
committed
platform/unix: fix build with -no-feature-systemtrayicon
make sure qdbustrayicon_p.h is included only once and only when systemtrayicon feature is enabled qdbuslistener: stop including unused qdbustrayicon_p.h this is a refactoring left-over Pick-to: 6.10 Change-Id: Ib848dae56e865dc05453f25c31a08fb2ec2e8305 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
1 parent 218ad11 commit 0de3a95

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

src/gui/platform/unix/qdbuslistener.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
#include <private/qguiapplication_p.h>
88
#include <qpa/qplatformintegration.h>
99
#include <qpa/qplatformservices.h>
10-
#include <private/qdbustrayicon_p.h>
10+
#include <qdbusconnection.h>
11+
#include <qfile.h>
1112
#include <qjsonarray.h>
1213
#include <qjsondocument.h>
1314
#include <qjsonobject.h>

src/gui/platform/unix/qgenericunixtheme.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,17 @@
3939
#include <QJsonObject>
4040
#include <QJsonValue>
4141
#include <QJsonParseError>
42-
#ifndef QT_NO_SYSTEMTRAYICON
43-
#include <private/qdbustrayicon_p.h>
4442
#include <private/qdbusmenubar_p.h>
4543
#endif
44+
#if QT_CONFIG(dbus) && QT_CONFIG(systemtrayicon)
45+
#include <private/qdbustrayicon_p.h>
4646
#endif
4747

4848
#include <private/qguiapplication_p.h>
4949
#include <qpa/qplatformintegration.h>
5050
#include <QtCore/QStandardPaths>
5151
#if QT_CONFIG(dbus)
5252
#include <QtDBus/QDBusConnectionInterface>
53-
#include <private/qdbustrayicon_p.h>
5453
#endif
5554
#if QT_CONFIG(mimetype)
5655
#include <QtCore/QMimeDatabase>

src/gui/platform/unix/qgnometheme.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
#include "qgnometheme_p.h"
66
#include <qpa/qplatformdialoghelper.h>
77
#include <qpa/qplatformfontdatabase.h>
8-
#if QT_CONFIG(dbus)
8+
#if QT_CONFIG(dbus) && QT_CONFIG(systemtrayicon)
99
# include <private/qdbustrayicon_p.h>
10+
#endif
11+
#if QT_CONFIG(dbus)
1012
# include <private/qdbusmenubar_p.h>
1113
#endif
1214
#include <qpa/qwindowsysteminterface.h>

src/gui/platform/unix/qkdetheme.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
#include <QPalette>
1010
#include <qpa/qwindowsysteminterface.h>
1111
#include "qdbuslistener_p.h"
12+
#if QT_CONFIG(dbus) && QT_CONFIG(systemtrayicon)
1213
#include <private/qdbustrayicon_p.h>
14+
#endif
1315
#include <private/qdbusplatformmenu_p.h>
1416
#include <private/qdbusmenubar_p.h>
1517
#include <QSettings>

0 commit comments

Comments
 (0)