Skip to content

Commit ed0e117

Browse files
committed
Update verbose and logging for model tuning
1 parent e6080ad commit ed0e117

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

Project.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ FiniteDiff = "6a86dc24-6348-571c-b903-95158fe2bd41"
1313
IrrationalConstants = "92d709cd-6900-40b7-9082-c6be49f344b6"
1414
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
1515
LogExpFunctions = "2ab3a3ac-af41-5b50-aa03-7779005ae688"
16+
Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
1617
MultivariateStats = "6f286f6a-111f-5878-ab1e-185364afe411"
1718
Optim = "429524aa-4258-5aef-a3af-852621145aeb"
1819
ProgressMeter = "92933f4c-e287-5a05-a399-4b506db050ca"
@@ -27,6 +28,7 @@ TreeParzen = "eb66a70c-a255-11e9-03ea-7ba6b2f22006"
2728
[compat]
2829
DifferentiationInterface = "0.6.53"
2930
FiniteDiff = "2.27.0"
31+
Logging = "1.11.0"
3032
TreeParzen = "0.3.4"
3133
julia = "1.9"
3234

src/DynamicFactorModels.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ using ProximalAlgorithms
3737
using TreeParzen
3838

3939
using ProgressMeter
40+
using Logging
4041

4142
using StatsAPI: aic, aicc, bic
4243

@@ -69,6 +70,7 @@ export
6970
model_tuning_ic!, model_tuning_cv!,
7071
loglikelihood,
7172
dof, nobs, nfactors, aic, aicc, bic,
73+
HP, # re-export from TreeParzen for convenience
7274

7375
# forecast
7476
forecast,

src/interface.jl

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,13 @@ function model_tuning_ic!(model::DynamicFactorModel, space::Dict, regularizer::F
295295
end
296296

297297
# model tuning
298-
best = fmin(objective, space, trials)
298+
if verbose
299+
best = best = fmin(objective, space, trials)
300+
else
301+
with_logger(NullLogger()) do
302+
best = fmin(objective, space, trials)
303+
end
304+
end
299305

300306
# refit
301307
fit!(model, regularizer = regularizer(best))

0 commit comments

Comments
 (0)