Core review #1

Author: einarf

pywavefront/texture.py

@@ -31,15 +31,24 @@
 # ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 # POSSIBILITY OF SUCH DAMAGE.
 # ----------------------------------------------------------------------------
+import os
 
 
 class Texture(object):
     def __init__(self, path):
         # Treat path as part of a file uri always using forward slashes
-        self.path = path.replace('\\', '/')
+        self.path = path.replace('\\', os.path.sep)
         self.image = None
 
     @property
     def image_name(self):
         """Wrap the old property name to not break compatibility"""
         return self.path
+
+    @image_name.setter
+    def image_name(self, value):
+        """Wrap the old property name to not break compatibility"""
+        self.path = value
+
+    def exists(self):
+        return os.path.exists(self.path)

test/test_material.py

@@ -56,3 +56,12 @@ def testSetEmissive(self):
         """set_emissive should set known values."""
         self.material.set_emissive()
         self.assertEqual(self.material.emissive, [0., 0., 0., 0.])
+
+
+class TestInvalidMaterial(unittest.TestCase):
+
+    def test_missing_texture(self):
+        """Running set_texture with a nonexistent file should raise an exception."""
+        material = pywavefront.material.Material('material')
+        material.set_texture('missing.file.do.not.create')
+        self.assertFalse(material.texture.exists())

test/test_texture.py

@@ -14,3 +14,8 @@ def testPathedImageName(self):
         """For Texture objects, the image name should be the last component of the path."""
         my_texture = pywavefront.texture.Texture(prepend_dir('4x4.png'))
         self.assertEqual(my_texture.path, prepend_dir('4x4.png'))
+
+    def testMissingFile(self):
+        """Referencing a missing texture file should raise an exception."""
+        texture = pywavefront.texture.Texture('missing.file.do.not.create')
+        self.assertFalse(texture.exists())