Skip to content

use PurePath if path not provided to preserve symlinks #20249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noobCodec wants to merge 8 commits into
base: master
Choose a base branch
from
Open

use PurePath if path not provided to preserve symlinks #20249

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1c028f7
Updates to config
noobCodec Nov 18, 2025
47dce0f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 18, 2025
9a25e91
Use Path and call .parent
noobCodec Nov 18, 2025
b5d0d2c
Merge branch 'fix_abs_path' of https://github.com/noobCodec/mypy into…
noobCodec Nov 18, 2025
e990364
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 18, 2025
1e1a503
update paths
noobCodec Nov 20, 2025
6f5c97b
Merge branch 'fix_abs_path' of https://github.com/noobCodec/mypy into…
noobCodec Nov 20, 2025
1ef94dc
Merge branch 'master' into fix_abs_path
noobCodec Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/test/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
from __future__ import annotations

import os.path
from pathlib import PurePath

provided_prefix = os.getenv("MYPY_TEST_PREFIX", None)
if provided_prefix:
PREFIX = provided_prefix
else:
this_file_dir = os.path.dirname(os.path.realpath(__file__))
this_file_dir = os.path.dirname(PurePath(__file__))
PREFIX = os.path.dirname(os.path.dirname(this_file_dir))
Copy link
Collaborator

@A5rocks A5rocks Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, I was thinking that we can replace os.path.dirname with the relevant pathlib operation (this_file_dir = (Path(__file__) / '..').resolve()?)

Copy link
Author

@noobCodec noobCodec Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an advantage of doing this over just this_file_dir = (Path(__file__)).resolve().parent ?

Copy link
Collaborator

@A5rocks A5rocks Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I just don't know pathlib APIs...

Copy link
Collaborator

@A5rocks A5rocks Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can also use .parent. Maybe you'll need to do str(...) to make sure it's a string path at the end, though...

On the other hand, maybe it would be nice to replace all os.path with pathlib.Path native things in this file? Up to you!


# Location of test data files such as test case descriptions.
Expand Down