Skip to content

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Dec 4, 2025

Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
@ned-deily
Copy link
Member

@FFY00 I just noticed all those cat commands being used for install steps and, without looking further into it, I wonder if those might be opening up some security issues. Typically, we use the install utility which does ensure specific permissions etc on installed files, something cat would not do.

@FFY00
Copy link
Member Author

FFY00 commented Dec 4, 2025

cat is only reading the build directory location here, install still does all the actual file touching.

That said, I really don't like this ideom. It has been around for a while, but unfortunately it's not easy to get rid of. I attempted it in GH-131761, but haven't had time to follow it through.

@ned-deily
Copy link
Member

cat is only reading the build directory location here, install still does all the actual file touching.

D'oh, sorry for the noise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants