Skip to content

gh-140454: Normalize the JIT stencils filename on Linux to avoid mismatches between the Makefile and the generator #140823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savannahostrowski merged 4 commits into from
Nov 4, 2025
Merged

gh-140454: Normalize the JIT stencils filename on Linux to avoid mismatches between the Makefile and the generator #140823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5f5274
gh-140454: Generate jit_stencils-*-pc-linux-gnu.h instead of ...unkno…
hroncok Oct 31, 2025
15b13d5
Fixup according to review
hroncok Nov 3, 2025
35e272c
fixup! Fixup according to review
hroncok Nov 3, 2025
f553ad5
make regen-configure
hroncok Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Build/2025-10-31-13-20-16.gh-issue-140454.gF6dCe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
When building the JIT, match the jit_stencils filename expectations in
Makefile with the generator script. This avoid needless JIT recompilation
during ``make install``.
4 changes: 2 additions & 2 deletions Tools/jit/_targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ def get_target(host: str) -> _COFF32 | _COFF64 | _ELF | _MachO:
optimizer = _optimizers.OptimizerAArch64
target = _COFF64(host, condition, args=args, optimizer=optimizer)
elif re.fullmatch(r"aarch64-.*-linux-gnu", host):
host = "aarch64-unknown-linux-gnu"
host = "aarch64-pc-linux-gnu"
condition = "defined(__aarch64__) && defined(__linux__)"
# -mno-outline-atomics: Keep intrinsics from being emitted.
args = ["-fpic", "-mno-outline-atomics"]
Expand All @@ -600,7 +600,7 @@ def get_target(host: str) -> _COFF32 | _COFF64 | _ELF | _MachO:
optimizer = _optimizers.OptimizerX86
target = _COFF64(host, condition, args=args, optimizer=optimizer)
elif re.fullmatch(r"x86_64-.*-linux-gnu", host):
host = "x86_64-unknown-linux-gnu"
host = "x86_64-pc-linux-gnu"
condition = "defined(__x86_64__) && defined(__linux__)"
args = ["-fno-pic", "-mcmodel=medium", "-mlarge-data-threshold=0"]
optimizer = _optimizers.OptimizerX86
Expand Down
Loading