-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-95461: Add some parameters in CreateKeyEx and OpenKeyEx in winreg #129903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aisk
wants to merge
28
commits into
python:main
Choose a base branch
from
aisk:enhance-winreg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e3fac96
Enhance winreg.OpenKeyEx and winreg.CreateKeyEx
aisk 59dfa3d
Add tests
aisk bba8ba6
Update sys.audit
aisk 47ea0ba
Add news entry
aisk d6251e0
Add documents
aisk f4f4fff
Fix sphinx error
aisk 1fd89db
Fix typo
aisk 28bf171
Regenerate files
aisk 94ed98b
Revert the changes on sys.audit
aisk b8261bb
Update comment
aisk 2475c0b
Apply suggestions from code review
aisk 913b21a
Update document for OpenKeyEx
aisk 483849a
Add document for CreateKeyEx
aisk bd57ba7
Fix CI
aisk 6eae434
Split OpenKey and OpenKeyEx
aisk 1b473ad
Check deprecated warning in test
aisk 5badb7a
Update document
aisk 7b9ffec
Fix rst lint errors
aisk b4e8d8b
Update generated files
aisk 580a348
Remove macro define by accident
aisk 76b947f
Merge branch 'main' into enhance-winreg
zooba 9e64cb2
Deprecate options in CreateKey too
aisk 5fab221
Remove the macro define again
aisk c4c2704
Merge remote-tracking branch 'upstream/main' into enhance-winreg
aisk 26b4e82
Update generate files
aisk e457112
Merge branch 'main' into enhance-winreg
serhiy-storchaka 7900598
Make options and create_only keyword-only for CreateKeyEx
aisk acc01c7
Make reserved keyword-only for OpenKeyEx
aisk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Windows/2025-02-10-00-00-00.gh-issue-95461.rBmMaH.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add *options* and *create_only* parameters to :meth:`winreg.CreateKeyEx`. | ||
| Add *options* parameter to :meth:`winreg.OpenKeyEx`. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is worth to make all new parameters keyword-only. Their order differs from the order in
RegCreateKeyExW(), so passing them as positional arguments will be errorprone.We can also deprecate passing
reserved(which should not be here at first place) andaccessby keyword, but this is a different issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for the review. I made the newly added parameters
optionsandcreate_onlykeyword-only-ed.