-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-95461: Add some parameters in CreateKeyEx and OpenKeyEx in winreg #129903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 21 commits
e3fac96
59dfa3d
bba8ba6
47ea0ba
d6251e0
f4f4fff
1fd89db
28bf171
94ed98b
b8261bb
2475c0b
913b21a
483849a
bd57ba7
6eae434
1b473ad
5badb7a
7b9ffec
b4e8d8b
580a348
76b947f
9e64cb2
5fab221
c4c2704
26b4e82
e457112
7900598
acc01c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Add *options* and *create_only* parameters to :meth:`winreg.CreateKeyEx`. | ||
| Add *options* parameter to :meth:`winreg.OpenKeyEx`. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is worth to make all new parameters keyword-only. Their order differs from the order in
RegCreateKeyExW(), so passing them as positional arguments will be errorprone.We can also deprecate passing
reserved(which should not be here at first place) andaccessby keyword, but this is a different issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for the review. I made the newly added parameters
optionsandcreate_onlykeyword-only-ed.